chore(antithesis): Add provider_kind in sample config - #2218
Conversation
Pyld54 asserts a v3 tagset back-reference resolves to an earlier tagset. Agent emits that back-reference only when a metric carries both a shared prefix tagset and its own tags. Previously we only ever emitted load that carried no shared prefix. This commit adds provider_kind into the sampled datadog.yaml. Agent will attach this as a global tag which acts as a shared prefix. 1/3 of configs will not have provider_kind present.
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
dd-octo-sts
Bot
added
the
area/test
|
Binary Size Analysis (Agent Data Plane)Baseline: e34c659 · Comparison: 14ee8b4 · diff ✅ Binary size difference within thresholdChanges by Module
Detailed Symbol Changes |
Regression Detector (Agent Data Plane)Run ID: Optimization Goals: ✅ No significant changes detectedFine details of change detection per experiment (3)Experiments configured
Bounds Checks: ✅ Passed (3)
ExplanationA change is flagged as a regression when |Δ mean %| > 5.00% in the regressing direction for its optimization goal AND SMP marks the experiment as a regression ( |
![datadog-prod-us1-4[bot]](https://avatars.githubusercontent.com/u/365230?s=60&v=4){kind=small}
There was a problem hiding this comment.
More details
The sampled provider_kind values are valid Agent configuration values, and the empty branch is omitted so existing timelines retain the default behavior. The change is isolated to Antithesis config generation; no behavioral regression or diff-only production hazard was identified.
🤖 Datadog Autotest · Commit 14ee8b4 · What is Autotest? · @DataDog review to ask questions · Any feedback? Reach out in #autotest
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 14ee8b4347
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| /// Cloud provider kind, sampled per timeline. | ||
| #[serde(skip_serializing_if = "String::is_empty")] | ||
| provider_kind: String, |
There was a problem hiding this comment.
Expand this field's Rustdoc beyond “sampled per timeline”: it does not explain that a nonempty value appends provider_kind:<value> to DogStatsD metrics, that empty/absent disables the tag, that the harness samples omission plus two fixed values, or who should change this test input. The repository requires configuration fields to document their behavioral impact, default, boundary behavior, and intended operator.
AGENTS.md reference: AGENTS.md:L149-L154
Useful? React with 👍 / 👎.
1 participant
Summary
Pyld54 asserts a v3 tagset back-reference resolves to an earlier
tagset. Agent emits that back-reference only when a metric carries both
a shared prefix tagset and its own tags. Previously we only ever emitted
load that carried no shared prefix.
This commit adds provider_kind into the sampled datadog.yaml. Agent will
attach this as a global tag which acts as a shared prefix. 1/3 of
configs will not have provider_kind present.
Change Type
How did you test this PR?
References