fix: enforce wheel install when --wheel-path is provided#269
Merged
Conversation
brettlangdon
requested review from
avara1986 and
emmettbutler
and removed request for
a team
This comment has been minimized.
This comment has been minimized.
emmettbutler
previously approved these changes
Jul 2, 2026
avara1986
previously approved these changes
Jul 3, 2026
emmettbutler
approved these changes
Jul 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now if the wheel path install fails we fallback to the editable install, which is not the intended behavior. If a wheel path is provided, the wheel install MUST succeed or else the command should fail.