Skip to content

[NO-TICKET] Skip flaky profiling spec until a full fix#5929

Merged
ivoanjo merged 1 commit into
masterfrom
ivoanjo/skip-flaky-profiling-spec
Jun 22, 2026
Merged

[NO-TICKET] Skip flaky profiling spec until a full fix#5929
ivoanjo merged 1 commit into
masterfrom
ivoanjo/skip-flaky-profiling-spec

Conversation

@ivoanjo

@ivoanjo ivoanjo commented Jun 22, 2026

Copy link
Copy Markdown
Member

What does this PR do?

This PR skips a flaky spec that hit
master:

Failures:

  1) Datadog::Profiling::Collectors::ThreadContext#sample_after_gvl_running if thread has not been sampled before does not sample the thread
     Failure/Error: expect(samples).to be_empty
       expected `[#<struct ProfileHelpers::Sample locations=[#<struct ProfileHelpers::Frame base_label="sleep", path="...26761, :state=>"sleeping", :"thread id"=>"14823 (39460)", :"thread name"=>"Timeout stdlib thread"}>].empty?` to be truthy, got false
     # ./spec/datadog/profiling/collectors/thread_context_spec.rb:1934:in `block (4 levels) in <top (required)>'
     # ./spec/spec_helper.rb:327:in `block (2 levels) in <top (required)>'
     # ./spec/spec_helper.rb:207:in `block (2 levels) in <top (required)>'
     # /usr/local/bundle/gems/webmock-3.26.2/lib/webmock/rspec.rb:39:in `block (2 levels) in <top (required)>'
     # /usr/local/bundle/gems/rspec-wait-0.0.10/lib/rspec/wait.rb:47:in `block (2 levels) in <top (required)>'
     # ./spec/support/execute_in_fork.rb:32:in `run'

Finished in 27.48 seconds (files took 1.09 seconds to load)
806 examples, 1 failure, 15 pending

Failed examples:

rspec ./spec/datadog/profiling/collectors/thread_context_spec.rb:1931 # Datadog::Profiling::Collectors::ThreadContext#sample_after_gvl_running if thread has not been sampled before does not sample the thread

We started fixing it in #5926 but it looks like the fix might be more involved than initially considered so let's unblock master while we figure out a good path.

Motivation:

Unblock master while we figure out a better solution

Change log entry

None.

Additional Notes:

N/A

How to test the change?

CI should be green, now that this test is skipped

**What does this PR do?**

This PR skips a flaky spec that hit
[master](https://github.com/DataDog/dd-trace-rb/actions/runs/27937925206/job/82664232085):

```
Failures:

  1) Datadog::Profiling::Collectors::ThreadContext#sample_after_gvl_running if thread has not been sampled before does not sample the thread
     Failure/Error: expect(samples).to be_empty
       expected `[#<struct ProfileHelpers::Sample locations=[#<struct ProfileHelpers::Frame base_label="sleep", path="...26761, :state=>"sleeping", :"thread id"=>"14823 (39460)", :"thread name"=>"Timeout stdlib thread"}>].empty?` to be truthy, got false
     # ./spec/datadog/profiling/collectors/thread_context_spec.rb:1934:in `block (4 levels) in <top (required)>'
     # ./spec/spec_helper.rb:327:in `block (2 levels) in <top (required)>'
     # ./spec/spec_helper.rb:207:in `block (2 levels) in <top (required)>'
     # /usr/local/bundle/gems/webmock-3.26.2/lib/webmock/rspec.rb:39:in `block (2 levels) in <top (required)>'
     # /usr/local/bundle/gems/rspec-wait-0.0.10/lib/rspec/wait.rb:47:in `block (2 levels) in <top (required)>'
     # ./spec/support/execute_in_fork.rb:32:in `run'

Finished in 27.48 seconds (files took 1.09 seconds to load)
806 examples, 1 failure, 15 pending

Failed examples:

rspec ./spec/datadog/profiling/collectors/thread_context_spec.rb:1931 # Datadog::Profiling::Collectors::ThreadContext#sample_after_gvl_running if thread has not been sampled before does not sample the thread
```

We started fixing it in #5926
but it looks like the fix might be more involved than initially
considered so let's unblock master while we figure out a good path.

**Motivation:**

Unblock master while we figure out a better solution

**Additional Notes:**

N/A

**How to test the change?**

CI should be green, now that this test is skipped
@ivoanjo ivoanjo requested review from a team as code owners June 22, 2026 15:06
@ivoanjo ivoanjo enabled auto-merge June 22, 2026 15:07
@dd-octo-sts dd-octo-sts Bot added the dev/testing Involves testing processes (e.g. RSpec) label Jun 22, 2026
@datadog-prod-us1-6

datadog-prod-us1-6 Bot commented Jun 22, 2026

Copy link
Copy Markdown

Pipelines  Tests

Fix all issues with BitsAI

⚠️ Warnings

🚦 1 Pipeline job failed

Check Pull Request CI Status | all-jobs-are-green   View in Datadog   GitHub Actions

ℹ️ Info

No other issues found (see more)

🧪 All tests passed
❄️ No new flaky tests detected

🎯 Code Coverage (details)
Patch Coverage: 100.00%
Overall Coverage: 90.01% (+0.02%)

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 6b56cfa | Docs | Datadog PR Page | Give us feedback!

@ivoanjo ivoanjo merged commit 22c838c into master Jun 22, 2026
392 of 394 checks passed
@ivoanjo ivoanjo deleted the ivoanjo/skip-flaky-profiling-spec branch June 22, 2026 15:50
@dd-octo-sts dd-octo-sts Bot added this to the 2.36.0 milestone Jun 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dev/testing Involves testing processes (e.g. RSpec)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants