Skip to content

Don't default DDA for controller revision - #3304

Open
khewonc wants to merge 1 commit into
mainfrom
khewonc/cr-defaulting
Open

Don't default DDA for controller revision#3304
khewonc wants to merge 1 commit into
mainfrom
khewonc/cr-defaulting

Conversation

@khewonc

@khewonc khewonc commented Jul 27, 2026

Copy link
Copy Markdown
Collaborator

What does this PR do?

Don't default DDA when creating controller revisions

Motivation

https://datadoghq.atlassian.net/browse/CONTP-1910

Additional Notes

Anything else we should know when reviewing?

Minimum Agent Versions

Are there minimum versions of the Datadog Agent and/or Cluster Agent required?

  • Agent: vX.Y.Z
  • Cluster Agent: vX.Y.Z

Describe your test plan

  1. Deploy the operator with DD_CREATE_CONTROLLER_REVISIONS=true: --set env[0].name=DD_CREATE_CONTROLLER_REVISIONS --set env[0].value=true
  2. Create a DDA with spec.global.site unset and annotations set:
apiVersion: datadoghq.com/v2alpha1
kind: DatadogAgent
metadata:
  name: datadog
  annotations:
    some.datadoghq.com/key: "tracked-value"
    some-other-tool/annotation: "should-be-excluded"
spec:
  global:
    credentials:
      apiKey: xxx
  1. Check the DDA controller revision kubectl get controllerrevisions and make sure the data matches the spec in 2 (spec.global.site is unset) and only annotation some.datadoghq.com/key: "tracked-value" is kept:
  annotations:
    some.datadoghq.com/key: tracked-value
  spec:
    global:
      credentials:
        apiKey: xxx

Checklist

  • PR has at least one valid label: bug, enhancement, refactoring, documentation, tooling, and/or dependencies
  • PR has a milestone or the qa/skip-qa label
  • All commits are signed (see: signing commits)

@khewonc
khewonc requested a review from a team July 27, 2026 22:10
@khewonc khewonc added the enhancement New feature or request label Jul 27, 2026
@khewonc khewonc added this to the v1.30.0 milestone Jul 27, 2026

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5eeb6a7168

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread internal/controller/datadogagent/controller_reconcile_v2.go
@datadog-datadog-prod-us1-2

Copy link
Copy Markdown

Code Coverage

🛑 Gate Violations

🎯 1 Code Coverage issue detected

A Patch coverage percentage gate may be blocking this PR.

Patch coverage: no data available (threshold: 80.00%)

ℹ️ Info

🎯 Code Coverage (details)
Patch Coverage: No data available
Overall Coverage: 47.26% (+0.01%)

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 5eeb6a7 | Docs | Datadog PR Page | Give us feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant