Onboard off public-images GitLab job-token trigger - #3303
Draft
AliDatadog wants to merge 1 commit into
Draft
Conversation
…h-image This converts all 7 publish jobs that previously triggered DataDog/public-images directly via GitLab job-token trigger to instead call `dd-pkg publish-image` against the artifact-gateway service, which drives the same public-images pipeline through a policy/audit layer. See https://datadoghq.atlassian.net/wiki/x/ooQkngE Ref: BARX-1948
|
🎯 Code Coverage (details) 🔗 Commit SHA: 41e9f98 | Docs | Datadog PR Page | Give us feedback! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DataDog/public-imagesis a GitHub repo synced to GitLab. Historically, repos publish public container images by triggering it directly through a legacy GitLabtrigger: project: DataDog/public-imagesjob (implicit GitLab job-token authorization). We're migrating off that mechanism in favor of add-pkg publish-imageCLI call against theartifact-gatewayservice, which internally still drives the samepublic-imagespipeline but goes through a policy/audit layer instead of relying on bare CI job-token trust.This is a CI-YAML-only change: no per-repo registration or allowlist step is required on the
artifact-gatewayside, since authorization is implicit via CI job identity.This PR converts all 7 jobs in
.gitlab-ci.ymlthat used the directtrigger: project: DataDog/public-imagesmechanism:trigger_e2e_operator_imagepublish_public_mainpublish_public_tagpublish_redhat_public_tagpublish_public_latestpublish_public_rc_latestpublish_redhat_public_latestEach job's own
stage,rules,needs, andvariables(e.g.IMG_SOURCES/IMG_DESTINATIONS/IMG_REGISTRIES) are unchanged — only the trigger mechanism itself is swapped, via a new shared.docker_publish_job_definitiontemplate that all 7 jobs nowextends.More context: https://datadoghq.atlassian.net/wiki/x/ooQkngE
Jira: https://datadoghq.atlassian.net/browse/BARX-1948
Test plan
ruby -ryaml -e "YAML.unsafe_load_file('.gitlab-ci.yml'); puts 'OK'"— YAML parses successfully