Skip to content

[TON-743] Add EKS add-on credential sync resources - #3291

Draft
fanny-jiang wants to merge 4 commits into
mainfrom
fanny/TON-723/operator-addon-ascp-credentials-sync
Draft

[TON-743] Add EKS add-on credential sync resources#3291
fanny-jiang wants to merge 4 commits into
mainfrom
fanny/TON-723/operator-addon-ascp-credentials-sync

Conversation

@fanny-jiang

Copy link
Copy Markdown
Contributor

What does this PR do?

Adds an opt-in credentials-sync contract to the Datadog Operator EKS add-on chart.

When managedAgentInstallationCredentials is configured, the chart renders:

  • ServiceAccount/datadog-ascp-sync
  • SecretProviderClass/datadog-api-key
  • a Linux EC2-only Deployment/datadog-ascp-secret-sync that keeps the CSI volume mounted

The SecretProviderClass syncs the configured AWS Secrets Manager value into datadog-secret[api-key] in the add-on namespace.

Motivation

This supports an intermediary EKS installation path where the instrumenter installs the Datadog Operator EKS add-on while the existing Lambda remains responsible for creating the DatadogAgent.

Additional Notes

This intentionally excludes the managed Agent lifecycle-intent resources from the broader add-on proposal.

The cluster must separately provide the AWS Secrets Store CSI Driver provider, EKS Pod Identity Agent, Kubernetes Secret sync support, and a Pod Identity association that grants the dedicated ServiceAccount access to the configured secret.

Before publishing the Marketplace add-on, the sync image should be mirrored and pinned in the Datadog Marketplace ECR repository.

Minimum Agent Versions

  • Agent: N/A
  • Cluster Agent: N/A

Describe your test plan

  • Linted the complete wrapper chart using the local upstream datadog-operator chart.
  • Rendered the enabled configuration and verified the ServiceAccount, SecretProviderClass, and Deployment contract.
  • Rendered the default configuration and verified that no credentials-sync resources are created.
  • Validated the Marketplace configuration schema as JSON.
  • Ran git diff --check.

Checklist

  • PR has at least one valid label: bug, enhancement, refactoring, documentation, tooling, and/or dependencies
  • PR has a milestone or the qa/skip-qa label
  • All commits are signed (see: signing commits)

@datadog-prod-us1-6

datadog-prod-us1-6 Bot commented Jul 21, 2026

Copy link
Copy Markdown

Tests  Code Coverage

🔄 Datadog auto-retried 1 job - 1 passed on retry View in Datadog

🎯 Code Coverage (details)
Patch Coverage: 100.00%
Overall Coverage: 47.15% (+0.19%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 6c9ce50 | Docs | Datadog PR Page | Give us feedback!

type: RuntimeDefault
containers:
- name: secret-sync
image: public.ecr.aws/amazonlinux/amazonlinux:2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we use marketplace ecr?

@fanny-jiang fanny-jiang added this to the v1.30.0 milestone Jul 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants