[PROF-15317] allow operator to use logging seccomp - #3229
Conversation
3d1a7d5 to
9276e2e
Compare
|
🎯 Code Coverage (details) 🔗 Commit SHA: 37c76c1 | Docs | Datadog PR Page | Give us feedback! |
9276e2e to
f9d5752
Compare
theomagellan
changed the title
82974d7 to
04f1180
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 160bc0a6e7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
fceecbd to
063c626
Compare
a8ee5c6 to
b6df78c
Compare
b6df78c to
37c76c1
Compare
|
|
||
| o.loggingSeccomp = featureutils.HasFeatureEnableAnnotation(dda, featureutils.EnableHostProfilerLoggingSeccompAnnotation) | ||
| if o.loggingSeccomp && !o.seccompEnabled { | ||
| o.logger.Info("host profiler: logging-seccomp annotation has no effect when seccomp is disabled") |
There was a problem hiding this comment.
nit: this will show up every 15s at reconciliation in info mode, so just flagging in case it should be debug instead. Info sounds appropriate nonetheless to surface something like this
There was a problem hiding this comment.
Thanks for the heads-up, I do agree that Info is appropriate, but I would rather not flood logs. Moving it to debug.
3 participants
What does this PR do?
This PR adds a new annotation to let Host Profiler deployments use a logging seccomp profile.
Motivation
This allows seccomp denials monitoring.
Additional Notes
Leverages DataDog/datadog-agent#53189
Minimum Agent Versions
Are there minimum versions of the Datadog Agent and/or Cluster Agent required?
Describe your test plan
Write there any instructions and details you may have to test your PR.
Checklist
bug,enhancement,refactoring,documentation,tooling, and/ordependenciesqa/skip-qalabel