test: make tests independent of containerID ordering#379
Merged
vickenty merged 4 commits intoJun 22, 2026
Conversation
KowalskiThomas
changed the title
containerID ordering
KowalskiThomas
force-pushed
the
kowalski/test-make-tests-independent-of-containerid-ordering
branch
3 times, most recently
from
e1b6c7d to
f9faf3f
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f9faf3f3b2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
KowalskiThomas
force-pushed
the
kowalski/test-make-tests-independent-of-containerid-ordering
branch
from
f9faf3f to
7a0082c
Compare
vickenty
reviewed
May 19, 2026
Contributor
|
Strange, race detector has picked up an issue with some of the tests on Windows. Might be a platform specific race condition (never seen one) or could be specific to Windows code we have. |
atanzu
requested changes
Jun 2, 2026
This comment has been minimized.
This comment has been minimized.
KowalskiThomas
force-pushed
the
kowalski/test-make-tests-independent-of-containerid-ordering
branch
from
a5d5e6e to
22e2d80
Compare
atanzu
approved these changes
Jun 22, 2026
gh-worker-dd-devflow-36fce6
Bot
added
mergequeue-status: queued
mergequeue-status: in_progress
and removed
mergequeue-status: queued
labels
gh-worker-dd-devflow-36fce6
Bot
added
mergequeue-status: done
and removed
mergequeue-status: in_progress
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR?
While trying to make some changes on
datadog-go, I've noticed that some tests would not work when run all at the same time. This should help with that when runningSpecifically, the container ID detection logic (in
container.go/container_linux.go) could return multiple candidate IDs, and tests were asserting on a specific one. The fix refactors the container detection to expose a deterministic/sorted result and updates the test helpers and test files (container_test.go,statsd_test.go,telemetry_test.go,service_check_test.go) to not rely on a particular ordering of container IDs.