statsd: add missing originDetection for DistributionSamples#366
Draft
KowalskiThomas wants to merge 2 commits into
Draft
statsd: add missing originDetection for DistributionSamples#366KowalskiThomas wants to merge 2 commits into
originDetection for DistributionSamples#366KowalskiThomas wants to merge 2 commits into
Conversation
KowalskiThomas
changed the title
DD_EXTERNAL_ENVoriginDetection for DistributionSample
KowalskiThomas
changed the title
originDetection for DistributionSampleoriginDetection for DistributionSamples
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes an issue in
datadog-gowhereDistributionSampleswould not properly forwardoriginDetection: c.clientEx.originDetectionto themetricstruct, resulting in possibly incomplete tags (some would not be inferred correctly).On top of that I had a CI flake on the first run. I changed the exact check because Claude Code's analysis was that the payload count is timing dependent so the same data can be split into more than one packet in certain cases "especially on Windows where the race detector has a higher overhead". The fact that we check the exact
TotalBytesSentshould be enough for coverage on "all data was sent", and having>= 1(instead of>= 22) telemetry packets sent also checks that the library is sending data as expected. So I think this is OK.