feat(healthplatform): collapse NEW/ONGOING states into ACTIVE#492
Draft
louis-cqrl wants to merge 1 commit into
Draft
feat(healthplatform): collapse NEW/ONGOING states into ACTIVE#492louis-cqrl wants to merge 1 commit into
louis-cqrl wants to merge 1 commit into
Conversation
Drop the distinction between NEW (first report) and ONGOING (repeated report) in the IssueState enum. Both cases mean "the issue is currently active", so a single ACTIVE value (wire value 1, formerly NEW) is sufficient. Wire value 2 (formerly ONGOING) is now reserved; agents no longer produce it and backends can discard it safely.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ISSUE_STATE_NEW(1) andISSUE_STATE_ONGOING(2) with a singleISSUE_STATE_ACTIVE(1) in theIssueStateproto enumISSUE_STATE_RESOLVED(3) is unchangedMotivation
The NEW/ONGOING distinction had no actionable meaning for consumers: both states mean "this issue is currently present". Collapsing them simplifies the agent state machine and the backend intake logic.
Backward compatibility
ISSUE_STATE_RESOLVED= 3 is unchangedTest plan