-
Notifications
You must be signed in to change notification settings - Fork 7
feat: support global excludes in rules.yaml config (feat #93) #94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
DataDave-Dev
merged 5 commits into
DataDave-Dev:main
from
YasserYG8:feat/global-excludes
Jul 8, 2026
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
fa6fddd
fix: improve Windows shell quoting and test environment portability (…
YasserYG8 d62cb18
Merge branch 'fix/issue-31-windows-compact' into feat/global-excludes
YasserYG8 30cf43e
feat: support global excludes in rules.yaml config (feat #93)
YasserYG8 2bdf242
merge : resolve conflicts with main
YasserYG8 9c95341
Merge branch 'main' into feat/global-excludes
DataDave-Dev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔒 Security & Privacy | 🟡 Minor | ⚡ Quick win
Runtime validation should reject empty strings in
global_exclude.The schema enforces
"minLength": 1on each item, but the runtime check at line 93 only validatesisinstance(x, str). An empty string glob pattern inglobal_excludewould pass runtime validation and could match all files, silently disabling every file-based rule. Align the runtime check with the schema contract.🛡️ Proposed fix
global_exclude = data.get("global_exclude", []) - if not isinstance(global_exclude, list) or not all(isinstance(x, str) for x in global_exclude): + if not isinstance(global_exclude, list) or not all(isinstance(x, str) and x for x in global_exclude): raise RulesError(f"{rules_path}: global_exclude must be a list of glob patterns.")📝 Committable suggestion
🤖 Prompt for AI Agents