Skip to content

[DT-3803] Update FROM to DUOS. - #3020

Merged
otchet-broad merged 1 commit into
developfrom
otchet-dt-3803-from-DUOS
Aug 14, 2026
Merged

[DT-3803] Update FROM to DUOS.#3020
otchet-broad merged 1 commit into
developfrom
otchet-dt-3803-from-DUOS

Conversation

@otchet-broad

Copy link
Copy Markdown
Contributor

Addresses

https://broadworkbench.atlassian.net/browse/DT-3803

Summary

  • Updates email to be sent from the name 'DUOS' so that sendgrid does not default to the local portion of the email address.
  • Adds test to confirm the property is set.

Have you read CONTRIBUTING.md lately? If not, do that first.

  • Label PR with a Jira ticket number and include a link to the ticket
  • Label PR with a security risk modifier [no, low, medium, high]
  • PR describes scope of changes
  • Get a minimum of one thumbs worth of review, preferably two if enough team members are available
  • Get PO sign-off for all non-trivial UI or workflow changes
  • Verify all tests go green
  • Test this change deployed correctly and works on dev environment after deployment

@sonarqubecloud

Copy link
Copy Markdown

@otchet-broad
otchet-broad marked this pull request as ready for review August 14, 2026 14:25
@otchet-broad
otchet-broad requested a review from a team as a code owner August 14, 2026 14:25
@otchet-broad
otchet-broad requested review from kevinmarete and rushtong and a lite review from Copilot and removed request for a team August 14, 2026 14:25

@rushtong rushtong left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice UX improvement 👍🏽

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates outgoing SendGrid emails to include a friendly “From” display name (“DUOS”) so email clients don’t fall back to showing only the local-part of the sender address, and adds a unit test assertion to ensure the name is set.

Changes:

  • Set the SendGrid Mail “From” field using new Email(fromAccount, "DUOS") in EmailService.
  • Add a test assertion verifying mail.getFrom().getName() equals "DUOS".

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/main/java/org/broadinstitute/consent/http/service/EmailService.java Adds a constant sender display name and applies it when constructing the SendGrid Mail “From” field.
src/test/java/org/broadinstitute/consent/http/service/EmailServiceTest.java Extends the sendMessage unit test to validate the “From” name is set to "DUOS".

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@otchet-broad
otchet-broad merged commit c760ecf into develop Aug 14, 2026
12 checks passed
@otchet-broad
otchet-broad deleted the otchet-dt-3803-from-DUOS branch August 14, 2026 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants