Editor 0.8.9-pre: openOMSI 0.3.45, bus stops and route authoring

.dockerignore

@@ -0,0 +1,11 @@
+# The Docker build context: the sources only (target/ alone is tens of GB).
+target/
+dist/
+.git/
+android/
+site/
+**/*.png
+!assets/**/*.png
+!crates/**/*.png
+docker/server/config/
+docker/server/.env

.gitattributes

@@ -0,0 +1 @@
+*.sh text eol=lf

.github/pull_request_template.md

@@ -2,18 +2,37 @@
 <!-- Describe what players will notice. One or two sentences are enough. -->
 
 ## How to test
-<!-- What testers should do with the test build (linked in a comment below once it is built): the map, the bus, the steps, and what should happen. Before/after screenshots help. -->
+<!-- What testers should do with the test build (linked in a comment below once it is built): the map, the bus, the steps, and what should happen. -->
+
+## Screenshots
+<!-- Required when something changes on screen, in the launcher or in the game: before and after, same place and same settings. Drag the images here; do not commit them. Write "No visible change" otherwise. -->
 
 ## What does this change, and why?
 <!-- Briefly explain the approach and the reason for it. Point out anything reviewers should look at first. -->
 
 ## What could break?
 <!-- What else uses the code you changed, and what you could not test yourself (a platform, VR, online play, a map, a mod). "Nothing that I know of" is a fine answer for a small fix. -->
 
+## Performance
+<!-- Required for a new feature: fill in the table. Same machine, map, bus, settings and place for the three columns; take the two releases from the Releases page.
+Frame times: run with OMSI_PROFILE=1 OMSI_PROFILE_JSON=<file> and --exit-after 120, then python3 scripts/compare-performance.py (on macOS, python3 scripts/bench-matrix.py runs it all).
+Memory: the game's memory after 2 minutes of driving (Windows: Task Manager, "Memory" column; macOS: Activity Monitor; Linux: RssAnon in /proc/<pid>/status).
+Write "No feature added" for a fix that adds none. -->
+
+| | This branch | Current release (0.x.y) | 0.2.30 |
+|---|---|---|---|
+| Average FPS | | | |
+| Slowest 1 % of frames (p99, ms) | | | |
+| Memory after 2 min (MB) | | | |
+
+Machine, map and settings:
+
 ## Checklist
 <!-- Tick what applies; strike through (~~like this~~) what does not apply to this change. -->
 - [ ] `cargo test --workspace` and `cargo build --release` pass
 - [ ] The pull request contains a single change
+- [ ] Before/after screenshots are in the description if anything changes on screen
+- [ ] A new feature has its performance table filled in (this branch, the current release, 0.2.30)
 - [ ] New or changed interface texts are in `crates/omsi-app/locales/app.yml`, in every language I can
 - [ ] Online play, saves, settings and mods made for the previous release still work, or the description says what changes
 - [ ] No original OMSI 2 content and no file of a megabyte or more in the commits

.github/workflows/apple.yml

@@ -54,6 +54,7 @@ jobs:
       - uses: Swatinem/rust-cache@v2
         with:
           key: apple
+          save-if: ${{ github.ref == 'refs/heads/main' }}
       - name: Tools
         run: |
           brew install xcodegen

.github/workflows/codeql.yml

@@ -5,11 +5,11 @@ on:
     branches: [main]
   pull_request:
   schedule:
-    - cron: "0 5 * * 1"
+    - cron: "0 5 * * *"
   workflow_dispatch:
 
 concurrency:
-  group: codeql-${{ github.ref }}
+  group: codeql-${{ github.event_name }}-${{ github.ref }}
   cancel-in-progress: ${{ github.event_name == 'pull_request' }}
 
 permissions:
@@ -26,16 +26,22 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        language: [rust, javascript-typescript, actions]
+        language: ${{ fromJSON((github.event_name == 'schedule' || github.event_name == 'workflow_dispatch') && '["rust", "javascript-typescript", "actions"]' || '["javascript-typescript", "actions"]') }}
     steps:
       - uses: actions/checkout@v7
       - uses: github/codeql-action/init@v4
         with:
           languages: ${{ matrix.language }}
           build-mode: none
+          # test files hold fixed passwords, salts and keys on purpose (a known answer, a
+          # password too short to take); a test module inside a source file cannot be told
+          # apart by its path and is still analysed
           config: |
             paths-ignore:
               - launcher/patches
+              - "**/tests/**"
+              - "**/tests.rs"
+              - "**/*_tests.rs"
       - uses: github/codeql-action/analyze@v4
         with:
           category: /language:${{ matrix.language }}

.github/workflows/editor-preview.yml

@@ -2,7 +2,7 @@
 name: Editor preview validation
 on:
   push:
-    branches: [editor-preview, "codex/spline-dimensions", "codex/editor-0.8.8.1", "update/**", "codex/editor-0.8.0-pre", "codex/editor-0.8.8-pre", "codex/windows-dxc-package-fix", "codex/editor-building-performance", "codex/editor-basis-0.3.33"]
+    branches: [editor-preview, "codex/editor-0.3.45-lines", "codex/spline-dimensions", "codex/editor-0.8.9-pre", "update/**", "codex/editor-0.8.0-pre", "codex/editor-0.8.8-pre", "codex/windows-dxc-package-fix", "codex/editor-building-performance", "codex/editor-basis-0.3.45"]
   pull_request:
     branches: [editor-preview]
   workflow_dispatch:
@@ -16,7 +16,7 @@ jobs:
         os: [ubuntu-22.04, windows-latest]
     runs-on: ${{ matrix.os }}
     env:
-      OPENOMSI_VERSION: 0.3.33-editor-0.8.8.1
+      OPENOMSI_VERSION: 0.3.45-editor-0.8.9-pre
     steps:
       - uses: actions/checkout@v7
       - uses: dtolnay/rust-toolchain@stable
@@ -95,7 +95,7 @@ jobs:
         if: runner.os == 'Windows'
         uses: actions/upload-artifact@v7.0.2
         with:
-          name: openOMSI-Editor-0.8.8.1-windows-x64
+          name: openOMSI-Editor-0.8.9-pre-windows-x64
           path: out/editor-windows/*
           if-no-files-found: error
           retention-days: 30

.github/workflows/pr_checks.yml

@@ -15,6 +15,7 @@ permissions:
 jobs:
   files:
     runs-on: ubuntu-latest
+    timeout-minutes: 15
     env:
       BASE: ${{ github.event.pull_request.base.sha }}
       LOCALES: crates/omsi-app/locales/app.yml
@@ -37,6 +38,7 @@ jobs:
             case "$f" in
               docs/openOMSI-Editor-Kurzanleitung.pdf|docs/openOMSI-Editor-Quick-Guide-EN.pdf) limit=8000000 ;;
             esac
+            [ "$f" = apple/Resources/Localizable.xcstrings ] && continue
             size=$(stat -c %s "$f" 2>/dev/null || echo 0)
             if [ "$size" -ge "$limit" ]; then
               echo "::error file=$f::$f is $((size / 1024)) KB. File exceeds its allowed size (1 MB normally, 8 MB for the two shipped PDF guides) (see CONTRIBUTING.md): link screenshots and videos in the pull request, and keep test data small."
@@ -46,6 +48,7 @@ jobs:
           exit $status
 
       - name: Translations
+        if: ${{ !cancelled() }}
         run: |
           if git diff --quiet "$BASE" HEAD -- "$LOCALES"; then
             echo "$LOCALES is not changed."
@@ -55,17 +58,31 @@ jobs:
           git show "$BASE:$LOCALES" > "$RUNNER_TEMP/app.base.yml" 2>/dev/null || : > "$RUNNER_TEMP/app.base.yml"
           python3 .github/scripts/check_locales.py "$RUNNER_TEMP/app.base.yml" "$LOCALES"
 
-  # No Rust file and no function may grow past its recorded size (+5 %), and new ones stay
-  # under 1500 / 300 lines: scripts/size-budget.sh, baseline in scripts/size-budget.txt.
-  size-budget:
-    runs-on: ubuntu-latest
-    steps:
-      - uses: actions/checkout@v7
-
+      # No Rust file and no function may grow past its recorded size (+5 %), and new ones stay
+      # under 1500 / 300 lines: scripts/size-budget.sh, baseline in scripts/size-budget.txt.
       - name: File and function sizes
+        if: ${{ !cancelled() }}
         run: bash scripts/size-budget.sh
 
       # Which crate may depend on which (nothing on omsi-app, the simulation on no renderer,
       # ...) and the app crate only shrinking: scripts/arch-guard.sh, rules in scripts/arch-rules.txt.
       - name: Crate layers
+        if: ${{ !cancelled() }}
         run: bash scripts/arch-guard.sh
+
+      - name: Drive page layouts
+        if: ${{ !cancelled() }}
+        run: |
+          if git diff --quiet "$BASE" HEAD -- launcher/ui launcher/tests .github/workflows/pr_checks.yml; then
+            echo "The launcher's page is not changed."
+            exit 0
+          fi
+          if node -e "process.exit(typeof WebSocket === 'function' ? 0 : 1)"; then
+            node launcher/tests/drive-check.mjs
+          else
+            node --experimental-websocket launcher/tests/drive-check.mjs
+          fi
+
+      - name: AI Lists state
+        if: ${{ !cancelled() }}
+        run: node launcher/tests/ai-lists-check.mjs