Skip to content

[Snyk] Fix for 2 vulnerabilities#91

Open
Dargon789 wants to merge 1 commit into
mainfrom
snyk-fix-87f25be5c0b404cfc0e684fa089bde4a
Open

[Snyk] Fix for 2 vulnerabilities#91
Dargon789 wants to merge 1 commit into
mainfrom
snyk-fix-87f25be5c0b404cfc0e684fa089bde4a

Conversation

@Dargon789

Copy link
Copy Markdown
Owner

snyk-top-banner

Snyk has created this PR to fix 2 vulnerabilities in the yarn dependencies of this project.

Snyk changed the following file(s):

  • packages/wallet/package.json

Note for zero-installs users

If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the .yarn/cache/ directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to run yarn to update the contents of the ./yarn/cache directory.
If you are not using zero-install you can ignore this as your flow should likely be unchanged.

⚠️ Warning
Failed to update the yarn.lock, please update manually before merging.

Vulnerabilities that will be fixed with an upgrade:

Issue Score
high severity Prototype Pollution
SNYK-JS-AXIOS-15252993
  828  
high severity Regular Expression Denial of Service (ReDoS)
SNYK-JS-AJV-15274295
  803  

Important

  • Check the changes in this PR to ensure they won't cause issues with your project.
  • Max score is 1000. Note that the real score may have changed since the PR was raised.
  • This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic


Learn how to fix vulnerabilities with free interactive lessons:

🦉 Regular Expression Denial of Service (ReDoS)
🦉 Prototype Pollution

@vercel

vercel Bot commented Feb 15, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
dargon789.uni.eth Ready Ready Preview, Comment Feb 15, 2026 5:48pm
uniswap-app-web Ready Ready Preview, Comment Feb 15, 2026 5:48pm

@snyk-io

snyk-io Bot commented Feb 15, 2026

Copy link
Copy Markdown

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @Dargon789, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request, automatically generated by Snyk, aims to enhance the project's security posture by resolving two high-severity vulnerabilities found in the packages/wallet module's dependencies. The changes involve a targeted dependency upgrade to mitigate potential risks associated with Prototype Pollution and Regular Expression Denial of Service.

Highlights

  • Security Vulnerability Fixes: Addressed two high-severity vulnerabilities: Prototype Pollution (SNYK-JS-AXIOS-15252993) and Regular Expression Denial of Service (ReDoS) (SNYK-JS-AJV-15274295) by upgrading affected dependencies.
  • Dependency Upgrade: Upgraded the axios package from version 1.12.2 to 1.13.5 in packages/wallet/package.json to resolve identified security issues.
Changelog
  • packages/wallet/package.json
    • Updated axios dependency from 1.12.2 to 1.13.5.
Activity
  • This pull request was automatically created by Snyk to address identified vulnerabilities.
  • A warning was noted that the yarn.lock file was not updated and requires manual intervention before merging.
  • The PR description provides links to Snyk reports and learning resources for the vulnerabilities.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request updates axios in packages/wallet to address a Prototype Pollution vulnerability. However, the fix is incomplete as packages/uniswap still uses the vulnerable version 1.12.2. Additionally, the PR claims to fix an ajv vulnerability, but no changes were made to apps/web/package.json where the vulnerable ajv version 8.11.0 is located. The failure to update yarn.lock also requires manual intervention to ensure dependency integrity.

"@uniswap/v3-sdk": "3.24.0",
"apollo3-cache-persist": "0.14.1",
"axios": "1.12.2",
"axios": "1.13.5",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

This security update for axios is inconsistent with the rest of the monorepo. packages/uniswap/package.json still references version 1.12.2, which remains vulnerable to Prototype Pollution. Dependency versions should be synchronized across all packages to ensure a consistent security posture and avoid bundling multiple versions of the same library. Furthermore, the version 1.13.5 is not a standard axios release; consider using a stable patched version like 1.7.4.

@Dargon789 Dargon789 linked an issue Mar 10, 2026 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[vc]: #[Snyk] Security upgrade ui from 0.0.0-use.local to 0.0.0#89

2 participants