Skip to content

Master#268

Open
Dargon789 wants to merge 16 commits into
mainfrom
master
Open

Master#268
Dargon789 wants to merge 16 commits into
mainfrom
master

Conversation

@Dargon789

Copy link
Copy Markdown
Owner

Description

Concise description of proposed changes

Additional Information

Your ENS/address:

Dargon789 and others added 13 commits April 20, 2026 15:31
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com>
* feact: add generateProxy

* Update packages/cli/src/utils/packages.ts

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com>

* Update LICENSE

Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com>

* Update package.json

Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com>

* Update pnpm-workspace.yaml

Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com>

* Update deploy/002_deploy_greetings_registry.ts

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com>

* Update contracts/scripts/fundingFromCoinbase.ts

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com>

* Update _scripts.js

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com>

* Refactor tsconfig.json to align with upstream

Removed unnecessary properties and merged with upstream changes.

Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com>

* Delete template-ethereum-contracts-main.zip

Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com>

* Delete .circleci/ci-web3-gamefi.yml

Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com>

* Delete .github/workflows/foundry-toolchain@v1

Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com>

* Update LICENSE

Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com>

---------

Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com>
Co-authored-by: googleworkspace-bot <googleworkspace-bot@google.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@codesandbox

codesandbox Bot commented May 19, 2026

Copy link
Copy Markdown

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

@vercel

vercel Bot commented May 19, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
my-vue-app-react Ready Ready Preview, Comment Jun 17, 2026 10:04am
template-ethereum-contracts Ready Ready Preview, Comment Jun 17, 2026 10:04am
template-ethereum-contracts-vue Ready Ready Preview, Comment Jun 17, 2026 10:04am

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @Dargon789, your pull request is larger than the review limit of 150000 diff characters

@snyk-io

snyk-io Bot commented May 19, 2026

Copy link
Copy Markdown

Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@github-actions

github-actions Bot commented May 19, 2026

Copy link
Copy Markdown

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a comprehensive Ethereum development environment, incorporating Foundry and Hardhat configurations, Solidity contracts for registries and tokens, and utility scripts for network management. Critical feedback identifies a malformed Dockerfile with conflicting image definitions, invalid dependency versions in package.json, and security vulnerabilities and logic errors in the custom script runner. Additional recommendations focus on code cleanliness, such as removing unused imports, eliminating redundant test logic, and adopting best practices for integer parsing and file formatting.

I am having trouble creating individual review comments. Click here to see my feedback.

Dockerfile (1-40)

critical

This Dockerfile appears to contain definitions for two separate images (one for Node.js, one for Python) concatenated together. A single Dockerfile can only define one image unless it's a correctly structured multi-stage build. The second FROM instruction on line 22 will cause build errors.

If you intend to define two separate services, they should be in two separate Dockerfiles (e.g., Dockerfile.node and Dockerfile.python).

contracts/package.json (18-53)

critical

The versions specified for @types/node (^25.6.2 on line 33) and typescript (^6.0.3 on line 49) are incorrect. The latest major versions for these packages are 20 and 5, respectively. These invalid version numbers will cause dependency installation to fail. Please correct them to valid, existing versions.

_scripts.js (76-163)

critical

The execute function constructs and runs shell commands using shell: true, which is dangerous as it can lead to command injection vulnerabilities if any of the inputs (fixedArgs, filepath, extra) are not properly sanitized. A malicious argument could allow for arbitrary command execution.

It is highly recommended to refactor this to avoid shell: true. Instead, pass the command and its arguments as an array to spawn or execFile.

_scripts.js (51-62)

critical

There is a syntax error in the execute function. The spawn(...) call is not correctly placed within the promise executor, which will cause the script to fail at parse time. It should be moved inside the new Promise(...) callback.

Additionally, when using shell: true, the second argument to spawn (the array of arguments) is ignored, so it can be removed for clarity.

	return new Promise((resolve, reject) => {
		const onExit = (error) => {
			if (error) {
				return reject(error);
			}
			resolve();
		};
		spawn(command, {
			stdio: 'inherit',
			shell: true,
		}).on('exit', onExit);
	});

hello_foundry/.gas-snapshot (2)

medium

This file is missing a newline character at the end. It's a common convention and good practice to end files with a newline.

CounterTest:test_Increment() (gas: 31851)

Counter/test/Counter.t.sol (4)

medium

The console import is not used in this test contract. It should be removed to keep the code clean.

import {Test} from "forge-std/Test.sol";

Counter/script/Counter.s.sol (4)

medium

The console import is not used in this contract. It should be removed to keep the code clean and avoid confusion.

import {Script} from "forge-std/Script.sol";

Counter/.gas-snapshot (2)

medium

This file is missing a newline character at the end. It's a common convention and good practice to end files with a newline.

CounterTest:test_Increment() (gas: 31851)

hello_foundry/script/Counter.s.sol (4)

medium

The console import is not used in this contract. It should be removed to keep the code clean and avoid confusion.

import {Script} from "forge-std/Script.sol";

hello_foundry/test/Counter.t.sol (4)

medium

The console import is not used in this test contract. It should be removed to keep the code clean.

import {Test} from "forge-std/Test.sol";

script/Counter.s.sol (4)

medium

The console import is not used in this contract. It should be removed to keep the code clean and avoid confusion.

import {Script} from "forge-std/Script.sol";

test/Counter.t.sol (4)

medium

The console import is not used in this test contract. It should be removed to keep the code clean.

import {Test} from "forge-std/Test.sol";

test/SimpleERC20.test.ts (28)

medium

This transfer call is redundant because the subsequent expect on line 30 also performs a transfer while checking for the event. You can remove this line to make the test cleaner and more focused on a single action.

utils/network.ts (82)

medium

It's a good practice to always specify the radix when using parseInt to avoid unexpected behavior with strings that could be interpreted as octal or hexadecimal. Please add the radix 10.

								? parseInt(process.env.HARDHAT_FORK_NUMBER, 10)

utils/network.ts (89)

medium

It's a good practice to always specify the radix when using parseInt to avoid unexpected behavior. Please add the radix 10 to this parseInt call.

							interval: process.env.MINING_INTERVAL.split(',').map((v) => parseInt(v, 10)) as [

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants