Move packaging and ninja from install_requires to setup_requires - #937
Merged
Conversation
Set `packaging` and `ninja` as build time dependencies rather than runtime dependencies.
10 tasks
|
For clarity, it is highly unusual to require the ninja build system and packaging at runtime. setup_requires is the list of packages required to build this package. install_requires is the list of packages required to run this package. |
|
Agreed, |
tridao
marked this pull request as ready for review
May 6, 2024 16:45
This was referenced May 1, 2025
playerzer0x
pushed a commit
to Liqhtworks/flash-attention
that referenced
this pull request
Jul 24, 2025
…-AILab#937) Set `packaging` and `ninja` as build time dependencies rather than runtime dependencies.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Set
packagingandninjaas build time dependencies rather than runtime dependencies.Xref conda-forge/staged-recipes#26239 (comment) where we're trying to package
flash-attnon conda-forge, and would like the setup.py metadata to be correct so that runningpip checkwould work.