Repository navigation
feat(audit): sponsorship graph, op-result reconciliation, Soroban footprint, WASM binding audits - #265
Open
techwizard-012 wants to merge 1 commit into
Conversation
…nt, wasm binding audits Adds four read-only inspection commands (sep-compliance pack 5): - sponsorship-graph-audit (ISSUE-158) - operation-result-reconciliation (ISSUE-159) - soroban-footprint-audit (ISSUE-160) - contract-wasm-binding-audit (ISSUE-161) Closes Dantama022#200 Closes Dantama022#201 Closes Dantama022#202 Closes Dantama022#203
|
@techwizard-012 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds four read-only inspection commands (
src/cli/commands/sep-compliance-5.ts), each with a service, docs, and unit tests:sponsorship-graph-audit(ISSUE-158): builds a sponsorship graph from Horizon account records. Each edge records its source path. Sponsors that weren't inspected are reported as unresolved. Cycles are detected only on the account-entry subgraph and reported as info.operation-result-reconciliation(ISSUE-159): matches envelope operations to result codes (using the existingdecodeTransactionResult), Horizon operation records (by sorted ID) and effects (by paging-token prefix). A missing effect is never reported as a failure.soroban-footprint-audit(ISSUE-160): summarizes the declared read-only/read-write footprint by key type and flags duplicates, read/write conflicts and unsupported key types.contract-wasm-binding-audit(ISSUE-161): checks the instance's executable type and confirms that the WASM hash matches both the ContractCode entry hash and the bytecode SHA-256. Missing data and RPC failures are reported as inconclusive.getLedgerEntriesis now exported fromwasm-integrity.tsso this command can reuse it.Closes #200
Closes #201
Closes #202
Closes #203
Validation
src/services/transaction-analyzer.tsfails to compile onmainalready (fetchAccountTransactionsis missing). The existingtransaction-result-analyzersuite fails onmainfor the same reason.tsc --noEmit: no errors in the new files. Errors already onmainremain infederation-response-report.ts,sep10-challenge-audit.ts,sponsorship-lifecycle-audit.tsandtrustline-exposure.ts.mainremain insrc/cli/index.tsandsrc/services/wasm-integrity.ts(left untouched).