Repository navigation
Conversation
…ade and fee-payer audits Closes Dantama022#156 Closes Dantama022#157 Closes Dantama022#198 Closes Dantama022#199
|
@pitah23 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds four read-only audit commands, registered via
src/cli/commands/account-tx-audits.ts:offer-staleness-audit(ISSUE-122: Add Stellar Account Offer Expiration and Stale Order Audit #156): paginated open-offer audit with a configurable age threshold, structural validation, and optional reference-price divergence. Age is reported as a staleness signal, never as an expiration.home-domain-identity-audit(ISSUE-123: Add Stellar Account Home-Domain Federation Identity Consistency Audit #157): compares the account'shome_domainwith thestellar.tomlACCOUNTSlist andORG_*metadata. A match is not treated as proof of ownership.contract-upgrade-compat-audit(ISSUE-156: Add Stellar Soroban Contract Upgrade Compatibility and Migration Audit #198): diffs two Soroban interfaces (WASM via the existingauditContractSpec, or a JSON spec) for added, removed and modified functions and types, using documented breaking/warning/info rules. Storage and runtime compatibility are never asserted.fee-payer-signature-audit(ISSUE-157: Add Stellar Transaction Envelope Fee-Payer and Signature Responsibility Audit #199): separates the fee payer (outer fee-bump source vs. inner source) from operation authorization, and checks thresholds against supplied account config using the existingverifyTransactionSignatures. Accounts without config are reported as inconclusive.Docs for each command are in
docs/.Closes #156
Closes #157
Closes #198
Closes #199
Validation
eslintpasses on all new and changed files.main, unchanged by this PR:tsc --noEmitfails on syntax errors infederation-response-report.ts,sep10-challenge-audit.ts,sponsorship-lifecycle-audit.tsandtrustline-exposure.ts; several existing test suites already fail, andcontract-spec-audit.tshas a type error under ts-jest, so it is mocked in the new upgrade test.