Skip to content

Add transaction signature coverage audit - #254

Open
lemarjohnny781 wants to merge 1 commit into
Dantama022:mainfrom
lemarjohnny781:feat/transaction-signature-coverage-audit
Open

lemarjohnny781 wants to merge 1 commit into
Dantama022:mainfrom
lemarjohnny781:feat/transaction-signature-coverage-audit

Conversation

@lemarjohnny781

@lemarjohnny781 lemarjohnny781 commented Oct 21, 2026 •

Copy link
Copy Markdown

Summary

  • Add a read-only CLI audit for transaction and fee-bump signature coverage.
  • Separate cryptographic verification from signer weights, account thresholds, operation sources, and supported extra-signer checks.
  • Report unavailable or unsupported authorization context as inconclusive, with JSON and human-readable output.
  • Document supported rules and limitations; add focused transaction fixtures and tests.
    closes ISSUE-118: Add Stellar Transaction Envelope Signature Coverage and Threshold Readiness Audit #152

Verification

  • npx jest --runInBand tests/transaction-signature-coverage-audit.test.ts (9 tests passed).
  • Existing fee-bump and operation-source tests pass. A related legacy passphrase-audit test still fails on its noKeys expectation; full-suite testing also encounters pre-existing TypeScript parse errors in src/services/trustline-exposure.ts.

@drips-wave

drips-wave Bot commented Oct 21, 2026

Copy link
Copy Markdown

@lemarjohnny781 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ISSUE-118: Add Stellar Transaction Envelope Signature Coverage and Threshold Readiness Audit

1 participant