ci: retry publishing the dev prerelease before giving up - #21
Merged
Conversation
The dev tag has to move to the new commit for Dan's Plugin Manager to see a new build, and moving it means deleting and recreating the release. A transient API failure inside that window left the repository with no dev release at all, with nothing to alert anyone: KDRTracker lost its dev release for a day to an HTTP 502, and Conquest-Recipes went stale in the same incident. Publishing is now attempted up to three times with a growing delay. Each attempt starts by deleting, so a half-finished attempt cannot wedge the next one, and an exhausted retry fails the run with an explicit message. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hardening for the
Dev Releaseworkflow added during the Dan's Plugin Manager experimental-channel rollout.The problem this fixes
For DPM to see a new experimental build, the
devtag has to move to the new commit — and moving it requires the release to be deleted and recreated, because editing a published release does not move its tag. That leaves a short window in which the repository has nodevrelease.A transient API failure inside that window strands the repository there. It is not hypothetical: within four days of the rollout, three repositories were affected.
HTTP 502devrelease at all for roughly a daydevbuild429devbuildNothing surfaced any of this. It was found by a manual sweep, and for anyone pinned to the experimental channel it would have appeared only as
/dpm updatequietly skipping the plugin.The change
Publishing is attempted up to three times, with a growing delay between attempts. Each attempt begins with the delete, so a half-finished previous attempt — release created, asset upload failed — cannot wedge the retry. If all three attempts fail, the run fails with a message saying the
devrelease may be missing until the workflow is re-run.Verification
The retry loop was extracted from the workflow and exercised in a shell against a stubbed
ghthat fails a configurable number of times:The
--notesbody and the one-JAR assertion are unchanged.drafted by Claude on behalf of Daniel Stephenson