Skip to content

Remove stale logging test - #450

Merged
Danielhiversen merged 1 commit into
Danielhiversen:masterfrom
MartinHjelmare:remove-stale-logging-test
Aug 22, 2026
Merged

Remove stale logging test#450
Danielhiversen merged 1 commit into
Danielhiversen:masterfrom
MartinHjelmare:remove-stale-logging-test

Conversation

@MartinHjelmare

@MartinHjelmare MartinHjelmare commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

This test was added in #316 to check that gql.transport.websockets debug log lines did not show up at info level. PR #353 removed the assertions and left the test body without assertions, when bumping gql and removing the level adjustment on the gql logger.

We can remove this test. It's not testing anything relevant and it's slowing down the test run.

@augmentcode

augmentcode Bot commented Aug 17, 2026

Copy link
Copy Markdown
🤖 Augment PR Summary

Summary: Removes the obsolete real-time logging test whose logging assertions were previously deleted.
Changes: Deletes the assertion-less async subscription/disconnect test and its now-unused asyncio and logging imports.

🤖 Was this summary useful? React with 👍 or 👎

@augmentcode augmentcode Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. No suggestions at this time.

Comment augment review to trigger a new review at any time.

@Danielhiversen
Danielhiversen merged commit 6d46381 into Danielhiversen:master Aug 22, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants