Fix dragging multiple nodes, use red/blue for science pack selection. - #166
Merged
Conversation
We previously introduced a regression when adding the shape/text feature which broke dragging multiple nodes around the graph after selecting them. Tests have been added to verify the behaviour. Additionally, when using the "Assign based on science packs" in Settings, we use blue to represent the selected state for the benefit of those with deuteranopia. The item/recipe chooser layout has also received a very minor tweak that removed the black border around the icons.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We previously introduced a regression when adding the shape/text feature which broke dragging multiple nodes around the graph after selecting them. Tests have been added to verify the behaviour.
Additionally, when using the "Assign based on science packs" in Settings, we use blue to represent the selected state for the benefit of those with deuteranopia.
The item/recipe chooser layout has also received a very minor tweak that removed the black border around the icons.