Skip to content

[Dependencies] Update to league/commonmark 2.10.1 #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DanielEScherzer merged 2 commits into from
Sep 9, 2026
Merged

[Dependencies] Update to league/commonmark 2.10.1 #97

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4dedef1
[Dependencies] Update to `league/commonmark` 2.10.1
DanielEScherzer Sep 9, 2026
b80abcf
bless
DanielEScherzer Sep 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"danielescherzer/commonmark-ext-pygments-highlighter": "0.2.0",
"danielescherzer/html-builder": "0.0.2",
"nikic/fast-route": "1.3.0",
"league/commonmark": "2.9.1",
"league/commonmark": "2.10.1",
"ramsey/pygments": "3.0.0",
"symfony/yaml": "7.4.12"
},
Expand Down
20 changes: 10 additions & 10 deletions tests/data/blog-highlighting.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,14 +17,14 @@
</ol>
</li>
<li><a href="#content-next-steps">Next steps</a></li>
</ol></div><div class="blog-content"><h1><a id="content-attributes-on-constants" href="#content-attributes-on-constants" class="heading-permalink" aria-hidden="true" title="Permalink"></a>Attributes on constants</h1><em>Tuesday, 29 April 2025</em>
</ol></div><div class="blog-content"><h1><a id="content-attributes-on-constants" href="#content-attributes-on-constants" class="heading-permalink" aria-hidden="true" tabindex="-1" title="Permalink"></a>Attributes on constants</h1><em>Tuesday, 29 April 2025</em>
<p>Earlier today, the <a rel="noopener noreferrer" target="_blank" class="external-link" href="https://wiki.php.net/rfc/attributes-on-constants">attributes-on-constants</a> RFC implementation was finally
merged. This was a project I worked on for months and a significant reason I
became more active as a PHP core developer. The initial motivation was to add a
way for constants to be marked as deprecated, so that MediaWiki could use that
feature to signal deprecated constants instead of relying solely on
documentation.</p>
<h2><a id="content-background" href="#content-background" class="heading-permalink" aria-hidden="true" title="Permalink"></a>Background</h2>
<h2><a id="content-background" href="#content-background" class="heading-permalink" aria-hidden="true" tabindex="-1" title="Permalink"></a>Background</h2>
<p>PHP 8 introduced support for <a rel="noopener noreferrer" target="_blank" class="external-link" href="https://www.php.net/manual/en/language.attributes.overview.php">attributes</a>, which allowed recording
metadata for classes, functions, methods, class properties, class constants,
and function parameters. In my presentation at the Fall 2024 edition of the
Expand Down Expand Up @@ -56,7 +56,7 @@ <h2><a id="content-background" href="#content-background" class="heading-permali
attributes, this wasn't merely a question of updating the engine to handle the
<code>#[\Deprecated]</code> attribute and make it usable on constants. First, PHP needed
to add support for attributes on constants in general.</p>
<h2><a id="content-feature" href="#content-feature" class="heading-permalink" aria-hidden="true" title="Permalink"></a>Feature</h2>
<h2><a id="content-feature" href="#content-feature" class="heading-permalink" aria-hidden="true" tabindex="-1" title="Permalink"></a>Feature</h2>
<p>The feature presented in the RFC is to allow using attributes on compile-time
non-class constants. By &quot;compile-time&quot;, I meant constants that were declared
like</p>
Expand All @@ -77,7 +77,7 @@ <h2><a id="content-feature" href="#content-feature" class="heading-permalink" ar
<code>define()</code> that would allow passing in attributes but not evaluating them was
something that I thought would be trickier; in retrospect, it might have been
easier than adding support for attributes on the <code>const</code>-defined constants.</p>
<h3><a id="content-compile-time-or-not" href="#content-compile-time-or-not" class="heading-permalink" aria-hidden="true" title="Permalink"></a>Compile time or not</h3>
<h3><a id="content-compile-time-or-not" href="#content-compile-time-or-not" class="heading-permalink" aria-hidden="true" tabindex="-1" title="Permalink"></a>Compile time or not</h3>
<p>The line between compile-time and run-time constants is not as straightforward
as just the use of <code>const</code> or the use of <code>define()</code>.</p>
<p>Consider the following PHP file (<code>include_class.php</code>):</p>
Expand Down Expand Up @@ -148,7 +148,7 @@ <h3><a id="content-compile-time-or-not" href="#content-compile-time-or-not" clas
are applied to the constant would need to be processed <em>at runtime</em>, something
that wasn't previously done because all other supported attribute targets were
compile-time constructs (classes, functions, parameters, etc.).</p>
<h3><a id="content-optimization-of-define" href="#content-optimization-of-define" class="heading-permalink" aria-hidden="true" title="Permalink"></a>Optimization of <code>define()</code></h3>
<h3><a id="content-optimization-of-define" href="#content-optimization-of-define" class="heading-permalink" aria-hidden="true" tabindex="-1" title="Permalink"></a>Optimization of <code>define()</code></h3>
<p>The line gets even blurrier when looking at PHP's built-in optimizer. As part
of &quot;pass 1&quot; with simple local optimizations (<a rel="noopener noreferrer" target="_blank" class="external-link" href="https://github.com/php/php-src/blob/3f03f7ed3d988567b5a59ae542579fd91cdfde42/Zend/Optimizer/pass1.c">pass1.c as of merge</a>),
for any function call where</p>
Expand All @@ -165,7 +165,7 @@ <h3><a id="content-optimization-of-define" href="#content-optimization-of-define
<li>the opcodes for the declaration of a runtime constant can be changed to match
those of a compile-time constant.</li>
</ul>
<h3><a id="content-implementation" href="#content-implementation" class="heading-permalink" aria-hidden="true" title="Permalink"></a>Implementation</h3>
<h3><a id="content-implementation" href="#content-implementation" class="heading-permalink" aria-hidden="true" tabindex="-1" title="Permalink"></a>Implementation</h3>
<p>If you want to take a look at the actual code, the implementing PR is available
<a rel="noopener noreferrer" target="_blank" class="external-link" href="https://github.com/php/php-src/pull/16952">on GitHub</a>. I'm not going to explain it in depth here, just with
broad strokes. The first three parts are for general attribute support, the last
Expand All @@ -189,7 +189,7 @@ <h3><a id="content-implementation" href="#content-implementation" class="heading
warning will be emitted, including any details included in the <code>#[\Deprecated]</code>
declaration.</li>
</ol>
<h2><a id="content-using" href="#content-using" class="heading-permalink" aria-hidden="true" title="Permalink"></a>Using</h2>
<h2><a id="content-using" href="#content-using" class="heading-permalink" aria-hidden="true" tabindex="-1" title="Permalink"></a>Using</h2>
<p>Now that constants support attributes, developers can apply userland attributes
to their constants to add various metadata. But, for me, the real power is in
the attributes that PHP itself provides, since those are able to hook into parts
Expand All @@ -214,7 +214,7 @@ <h2><a id="content-using" href="#content-using" class="heading-permalink" aria-h
<p>My hope is that MediaWiki and other libraries will apply this attribute to send
warnings where previously only documentation could be used to indicate
deprecations.</p>
<h3><a id="content-backwards-compatibility" href="#content-backwards-compatibility" class="heading-permalink" aria-hidden="true" title="Permalink"></a>Backwards compatibility</h3>
<h3><a id="content-backwards-compatibility" href="#content-backwards-compatibility" class="heading-permalink" aria-hidden="true" tabindex="-1" title="Permalink"></a>Backwards compatibility</h3>
<p>However, using this attribute in MediaWiki, and more generally, in any tool that
supports versions of PHP before 8.5 (which isn't even out yet!) presents a
problem: because using attributes on constants requires syntax that was invalid
Expand Down Expand Up @@ -256,7 +256,7 @@ <h3><a id="content-backwards-compatibility" href="#content-backwards-compatibili
that would trigger <code>eval()</code> with the constant, and in PHP 8.4 it would just
delegate to the <code>define()</code> function. I might spend a few days developing that
library if I get the urge to write some code.</p>
<h3><a id="content-in-php-stubs" href="#content-in-php-stubs" class="heading-permalink" aria-hidden="true" title="Permalink"></a>In PHP stubs</h3>
<h3><a id="content-in-php-stubs" href="#content-in-php-stubs" class="heading-permalink" aria-hidden="true" tabindex="-1" title="Permalink"></a>In PHP stubs</h3>
<p>Now that constants can be deprecated with attributes, the various constants that
PHP provides can be updated with more informative error messages by adding the
attribute to those internal constants. This would mirror the addition of the
Expand All @@ -283,7 +283,7 @@ <h3><a id="content-in-php-stubs" href="#content-in-php-stubs" class="heading-per
updated to support attributes on constants. Only once a new version of the
parser is available that supports the new syntax will it be possible to populate
more helpful error messages for internal constants.</p>
<h2><a id="content-next-steps" href="#content-next-steps" class="heading-permalink" aria-hidden="true" title="Permalink"></a>Next steps</h2>
<h2><a id="content-next-steps" href="#content-next-steps" class="heading-permalink" aria-hidden="true" tabindex="-1" title="Permalink"></a>Next steps</h2>
<p>Now that it is possible to have the engine trigger deprecation notices for
global constants, I've started looking into the other places where
<code>#[\Deprecated]</code> support would be useful, either for MediaWiki or for libraries
Expand Down
Loading