Add cartridge banking, DMA, joypad, and ROM tests - #10
Open
DanielCuevas1208 wants to merge 6 commits into
Open
Conversation
DanielCuevas1208
commented
Aug 4, 2026
DanielCuevas1208
left a comment
Owner
Author
There was a problem hiding this comment.
Do not merge this revision yet. The Game Boy JOYP selection logic is reversed. Bits 4 and 5 are active-low, but Joypad.read() selects a column when the stored bit is nonzero. The returned register value also drops the stored select bits. Correct the register behavior and update the tests before merge. Keep the joypad interrupt test separate from the selection test.
This was referenced Aug 4, 2026
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Review status
Do not merge yet.
The JOYP select bits use active-low logic. The current code uses active-high logic and does not return the stored select bits. Correct the register behavior and update its tests.
Validation
Run the unit tests, test ROMs, build, and headless checks after the correction.