Firefox#20
Open
Daniel-W-Innes wants to merge 13 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR moves Firefox setup from an ad-hoc package install into a declarative Home Manager programs.firefox configuration, intended for the desktop host profile.
Changes:
- Remove
firefoxfromhome.packagesand enable/configure Firefox via Home Manager instead. - Add a new
home/firefox.nixmodule that declares a Firefox profile with bookmarks, search engines, and extension installation. - Set
home-manager.backupFileExtension = "bak"for all configured hosts to avoid clobbering existing files during activation.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
home/gui.nix |
Stops installing Firefox as a plain package (preparing for Home Manager-managed Firefox). |
home/firefox.nix |
New declarative Firefox module: profile, bookmarks, search engines, and XPI-based extensions. |
home/desktop.nix |
Imports the new Firefox module for the desktop profile. |
flake.nix |
Adds Home Manager backup extension configuration for each NixOS configuration. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Declarative Firefox config.