12.0.7 readiness: feature-detect MenuUtil tooltip + DoReadyCheck move#154
Open
Krathe82 wants to merge 1 commit into
Open
12.0.7 readiness: feature-detect MenuUtil tooltip + DoReadyCheck move#154Krathe82 wants to merge 1 commit into
Krathe82 wants to merge 1 commit into
Conversation
PTR API audit (Gethe 12.0.5 vs 12.0.7 tags) found two DF call sites touched by the patch: - MenuUtil.ShowTooltip/HideTooltip (addon compartment tooltip) are DEPRECATED in 12.0.7 (Deprecated_12_0_7.lua) in favour of the *Ex variants taking an explicit tooltip; the old names only survive behind the loadDeprecationFallbacks CVar. Feature-detect: use ShowTooltipEx/ HideTooltipEx + GetAppropriateTooltip() when present (12.0.7), fall back to the old API (12.0.5, where the Ex variants don't exist). - DoReadyCheck moves into C_PartyInfo in 12.0.7 and Blizzard migrated their own callers with NO compat shim for the old global. The permanent mover's Ready Check action now prefers C_PartyInfo.DoReadyCheck, falling back to the global on 12.0.5. Both dual-compatible; no behaviour change on live.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With addons disabled on the PTR, we audited the full 12.0.5 → 12.0.7 interface diff (generated API docs, secure templates, restricted environment, deprecation list) against everything the addon calls. The good news:
C_UnitAuras, the secure group header layer, the secret-values predicates, and the Duration object pipeline are all unchanged or purely additive. Two call sites are affected by the patch, both fixed here with feature detection so the same code runs correctly on live today:MenuUtil.ShowTooltip/HideTooltipare deprecated in 12.0.7 (listed inDeprecated_12_0_7.lua) in favour ofShowTooltipEx/HideTooltipExtaking an explicit tooltip — the old names only survive behind theloadDeprecationFallbacksCVar. The addon-compartment tooltip now uses the Ex variants (+GetAppropriateTooltip()) when present, falling back to the old API on 12.0.5 where the Ex variants don't exist.DoReadyCheckmoves intoC_PartyInfoin 12.0.7, and Blizzard migrated their own UI callers with no compat shim for the old global. The permanent mover's Ready Check action now prefersC_PartyInfo.DoReadyCheck, falling back to the global on 12.0.5.No behaviour change on live; both paths activate automatically when 12.0.7 ships.