Skip to content

Apply FileSystemRights recursively #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
froce wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Apply FileSystemRights recursively #15

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
17f134c
Apply FileSystemRights recursively
froce May 18, 2022
db41a1d
Merge branch 'main' into hotfix/recursively-apply-filesystem-rights
Tyler-IN May 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 41 additions & 2 deletions DW2Net6Win/Isolation/Windows.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,12 +234,51 @@ private static void AllowFileAccess(AppContainerProfile container, string path,
}
}

foreach (var file in Directory.EnumerateFiles(path, "*", SearchOption.TopDirectoryOnly))
foreach (var directory in Directory.EnumerateDirectories(path, "*", SearchOption.AllDirectories))
{
var di = new DirectoryInfo(directory);
var fs = di.GetAccessControl(AccessControlSections.Access);
if (!fs.AreAccessRulesProtected) continue;

var existing2 = fs.GetAccessRules(true, false, typeof(SecurityIdentifier))
.Cast<FileSystemAccessRule>()
.ToArray();
foreach (var rule in existing2)
{
if (rule.FileSystemRights == dirRights && rule.IdentityReference == sid)
{
fs.RemoveAccessRule(rule);
}
}

fs.SetAccessRuleProtection(false, false);
try
{
di.SetAccessControl(fs);
}
catch (Exception ex)
{
throw new SecurityException($"Unable to apply AppContainer restrictions to {directory}", ex);
}
}

foreach (var file in Directory.EnumerateFiles(path, "*", SearchOption.AllDirectories))
{
var fi = new FileInfo(file);
var fs = fi.GetAccessControl(AccessControlSections.Access);
if (!fs.AreAccessRulesProtected) continue;
fs.PurgeAccessRules(sid);

var existing2 = fs.GetAccessRules(true, false, typeof(SecurityIdentifier))
.Cast<FileSystemAccessRule>()
.ToArray();
foreach (var rule in existing2)
{
if(rule.FileSystemRights == dirRights && rule.IdentityReference == sid)
{
fs.RemoveAccessRule(rule);
}
}

fs.SetAccessRuleProtection(false, false);
try
{
Expand Down