fix(rust_brain): preserve HLC on snapshot restore, bulk_write, and gossip - #78
Draft
cursor[bot] wants to merge 1 commit into
Draft
fix(rust_brain): preserve HLC on snapshot restore, bulk_write, and gossip#78cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
…ssip After snapshot restore, nodes were assigned fresh HLC timestamps instead of the values stored in the snapshot. Causal successor writes and gossip replays with pre-crash HLC were rejected with TimestampRegression, causing silent data loss in disaster-recovery and multi-node deployments. - Add _parse_hlc() for wire/snapshot HLC normalisation - restore_from_file: restore hlc, update global HLC, hold lock during restore - bulk_write: pass through hlc from row payloads - gossip.receive: apply hlc, reject stale updates, skip missing-hlc overwrites - Add regression tests in test_hlc_snapshot_gossip.py Co-authored-by: Daniel <DJLougen@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug and impact
After
restore_from_file(), nodes were assigned fresh HLC timestamps instead of the values stored in the snapshot. Causal successor writes and gossip replays with pre-crash HLC were rejected withTimestampRegression, causing silent data loss in disaster-recovery and multi-node deployments.Concrete trigger: Snapshot a node with
hlc=(5000, 10, "nodeA"), restore, then write a causally later value withhlc=(5000, 11, "nodeA")— the write is rejected because restore assigned a fresh wall-clock HLC.Root cause
restore_from_file()constructedMemoryNodewithout passing the storedhlcfield, so the dataclass default (_hlc.now()) was used. The same gap existed inbulk_write()(no HLC passthrough) andgossip.receive()(no HLC handling).Fix
_parse_hlc()for wire/snapshot HLC normalisation (with legacy fallback fromts_ns)restore_from_file: restorehlc, call_hlc.update()per node, hold lock during restorebulk_write: pass throughhlcfrom row payloadsgossip.receive: applyhlc, reject stale updates, skip missing-HLC overwrites on existing keysValidation
TimestampRegression)test_hlc_snapshot_gossip.py,test_enterprise_backup.py,test_gossip.py,test_rust_brain.py,test_rust_brain_concurrency.py