fix(rust_brain): preserve HLC across snapshot restore and gossip - #73
Draft
cursor[bot] wants to merge 1 commit into
Draft
fix(rust_brain): preserve HLC across snapshot restore and gossip#73cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
restore_from_file() assigned fresh HLC timestamps instead of reading stored values from snapshots. After disaster recovery, gossip replays and causal successor writes were rejected with TimestampRegression, causing silent data loss in distributed deployments. - Add _parse_hlc() for snapshot/wire normalization - Restore HLC on snapshot load and advance global HLC - Pass HLC through bulk_write and gossip.receive() - Hold lock during restore mutation - Add regression tests in test_hlc_snapshot_gossip.py Co-authored-by: Daniel <DJLougen@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug and impact
restore_from_file(),bulk_write(), andgossip.receive()did not preserve or apply Hybrid Logical Clock (HLC) timestamps introduced in v0.6.0. After snapshot restore, gossip replays and causally valid successor writes were rejected withTimestampRegression, causing silent data loss in disaster-recovery and multi-node deployments.Concrete trigger: Node A writes key
kwith HLC(5000, 10, nodeA), snapshots, crashes. Node B restores the snapshot. Node A (or gossip) attempts a successor write with HLC(5000, 11, nodeB)— rejected because restore assigned a fresh wall-clock HLC instead of the snapshot value.Root cause
v0.6.0 added HLC monotonic enforcement to
remember()and serializes HLC into_dict(), butrestore_from_file()createdMemoryNodewithout readinghlcfrom the snapshot,bulk_write()did not passhlc, andgossip.receive()ignored HLC on incoming events.Fix
_parse_hlc()for snapshot/wire normalization (with legacy fallback for pre-v0.6.0 snapshots)_hlc.update()bulk_writeandgossip.receive()Validation
TimestampRegressiontest_hlc_snapshot_gossip.py,test_enterprise_backup.py,test_gossip.py,test_rust_brain.py