fix(stack): native compress telemetry NameError - #64
Draft
cursor[bot] wants to merge 1 commit into
Draft
Conversation
The native compress path builds a CompressedTurn in `result` but telemetry still referenced the Python-only `out` variable, causing NameError when backend=native, rust_brain is explicit, and telemetry is enabled. Co-authored-by: Daniel <DJLougen@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug and impact
HiveStack.compress()crashes withNameErrorwhen:backend="native"(orHIVE_BACKEND=nativewith an explicitrust_brain)The native path builds
resultbut telemetry still referenced the Python-onlyoutvariable.Root cause
PR #62 added a native compress branch that assigns
native_out/result, but leftrecord_compression()readingout.role,out.original_tokens, etc. from the Python path.Fix
Record telemetry from
resultfields (same shape for both backends).Validation
NameErrorwith mockednative_compresstest_native_compress_with_telemetry_does_not_crash