Skip to content

GetConfigURLsFromVIN fixing response structure#178

Merged
JamesReate merged 1 commit into
mainfrom
pr-4878-bug-macaron-errror-decoding-vehicle
Mar 23, 2026
Merged

GetConfigURLsFromVIN fixing response structure#178
JamesReate merged 1 commit into
mainfrom
pr-4878-bug-macaron-errror-decoding-vehicle

Conversation

@LDMO-Dev

@LDMO-Dev LDMO-Dev commented Mar 21, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Proposed Changes

Impacted Routes

Route: /device-config/vin/:vin/urls

  • Made changes to expected response structure to match old structure

Current structure:

{
  "isTemplateUpToDate":false,
  "isFirmwareUpToDate":false,
  "template":{
    pidUrl: "..",
    dbcUrl: "..",
    deviceSettingUrl: "..",
  }
}

Proposed structure:

{
    pidUrl: "..",
    dbcUrl: "..",
    deviceSettingUrl: "..",
}

@linear

linear Bot commented Mar 21, 2026

Copy link
Copy Markdown

PR-4878 [BUG] Macaron errror decoding vehicle.

@LDMO-Dev
LDMO-Dev marked this pull request as ready for review March 21, 2026 04:28
@LDMO-Dev
LDMO-Dev requested a review from JamesReate March 21, 2026 04:28
@JamesReate
JamesReate merged commit 22e629f into main Mar 23, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JamesReate JamesReate Awaiting requested review from JamesReate

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@LDMO-Dev @JamesReate