Skip to content

feat: add credit tracker integration#161

Merged
KevinJoiner merged 5 commits into
mainfrom
ex-3648-add-credit-tracker-check-to-telemetry
Jun 6, 2025
Merged

feat: add credit tracker integration#161
KevinJoiner merged 5 commits into
mainfrom
ex-3648-add-credit-tracker-check-to-telemetry

Conversation

@KevinJoiner

Copy link
Copy Markdown
Contributor
  • Add credit tracker service and middleware
  • Update auth and config for credit tracking
  • Add e2e tests for credit tracker functionality
  • Update helm charts for new feature

- Add credit tracker service and middleware
- Update auth and config for credit tracking
- Add e2e tests for credit tracker functionality
- Update helm charts for new feature
@linear

linear Bot commented Jun 4, 2025

Copy link
Copy Markdown

This comment was marked as outdated.

Comment thread internal/dtcmiddleware/dctmiddleware.go
@KevinJoiner
KevinJoiner requested a review from Copilot June 4, 2025 19:38

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR integrates a new credit tracker service along with its middleware, updates auth and config to support credit tracking, and includes e2e tests and helm chart changes.

  • Adds credit tracker client and associated methods.
  • Integrates new middleware for handling credit deductions/refunds.
  • Updates e2e tests and helm charts to support the new feature.

Reviewed Changes

Copilot reviewed 14 out of 14 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
pkg/errorhandler/errorhandler.go Adds helper functions for error classification.
internal/service/credittracker/credittracker.go Implements the credit tracker client with retry logic.
internal/repositories/repositories.go Updates error handling from internal to bad request.
internal/dtcmiddleware/dctmiddleware.go Introduces middleware for credit tracking within GraphQL.
internal/config/settings.go Adds credit tracker endpoint to settings.
internal/auth/jwt.go Updates GetValidatedClaims to use context.
internal/app/app.go Integrates credit tracker middleware into server setup.
go.mod Adds and updates dependencies for credit tracker.
e2e/setup_test.go Sets up test container for credit tracker.
e2e/permission_test.go Updates expected error format in permission tests.
e2e/credit_tracker_test.go Adds e2e tests using a mock credit tracker gRPC server.
charts/telemetry-api/values.yaml Updates helm values for credit tracker endpoint.
charts/telemetry-api/values-prod.yaml Updates production helm values for credit tracker endpoint.

Comment thread internal/service/credittracker/credittracker.go Outdated
Comment thread internal/service/credittracker/credittracker.go Outdated
Comment thread e2e/credit_tracker_test.go Outdated

@elffjs elffjs left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We looked over this together on Wednesday, it seems good to me.

@KevinJoiner
KevinJoiner merged commit 463635b into main Jun 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants