Skip to content

ex-3587-filter-attestations-by-id #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Allyson-English merged 7 commits into from
Jun 9, 2025
Merged

ex-3587-filter-attestations-by-id #151

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
4ff89b0
filter attestations by id
Allyson-English May 22, 2025
9e1fd6e
test
Allyson-English May 22, 2025
7f3f80f
Merge branch 'main' into ex-3587-filter-attestations-by-id
Allyson-English May 27, 2025
e6de734
get latest cloud event method
Allyson-English May 27, 2025
334dd58
remove getAttestation (singular)
Allyson-English May 29, 2025
23fce98
make generate
Allyson-English May 29, 2025
90eae07
Merge branch 'main' into ex-3587-filter-attestations-by-id
Allyson-English Jun 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion internal/graph/attestation.resolvers.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

14 changes: 13 additions & 1 deletion internal/graph/generated.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions internal/graph/model/models_gen.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 5 additions & 1 deletion internal/repositories/attestation/attestation.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ func New(indexService indexRepoService, chainID uint64, vehicleAddress common.Ad
}

// GetAttestations fetches attestations for the given vehicle.
func (r *Repository) GetAttestations(ctx context.Context, vehicleTokenID uint32, filter *model.AttestationFilter) ([]*model.Attestation, error) {
func (r *Repository) GetAttestations(ctx context.Context, vehicleTokenID int, filter *model.AttestationFilter) ([]*model.Attestation, error) {
vehicleDID := cloudevent.ERC721DID{
ChainID: r.chainID,
ContractAddress: r.vehicleAddress,
Expand Down Expand Up @@ -70,6 +70,10 @@ func (r *Repository) GetAttestations(ctx context.Context, vehicleTokenID uint32,
if filter.Limit != nil {
limit = *filter.Limit
}

if filter.ID != nil {
opts.Id = &wrapperspb.StringValue{Value: *filter.ID}
}
}

cloudEvents, err := r.indexService.GetAllCloudEvents(ctx, opts, int32(limit))
Expand Down
10 changes: 5 additions & 5 deletions internal/repositories/attestation/attestation_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ func (m *MockRow) ScanStruct(any) error {
return nil
}

func TestAttestation(t *testing.T) {
func TestGetAttestations(t *testing.T) {
// Initialize variables
ctx := context.Background()
validVehTknID := int(123)
Expand Down Expand Up @@ -88,7 +88,7 @@ func TestAttestation(t *testing.T) {
tests := []struct {
name string
mockSetup func()
vehTknID uint32
vehTknID int
filters *model.AttestationFilter
expectedAtts []*model.Attestation
expectedErr bool
Expand All @@ -101,7 +101,7 @@ func TestAttestation(t *testing.T) {
defaultEvent,
}, nil)
},
vehTknID: uint32(validVehTknID),
vehTknID: validVehTknID,
expectedAtts: []*model.Attestation{
&model.Attestation{
ID: id,
Expand Down Expand Up @@ -130,7 +130,7 @@ func TestAttestation(t *testing.T) {
Source: &validSigner,
Limit: &limit,
},
vehTknID: uint32(validVehTknID),
vehTknID: validVehTknID,
expectedAtts: []*model.Attestation{
&model.Attestation{
ID: id,
Expand All @@ -149,7 +149,7 @@ func TestAttestation(t *testing.T) {
mockSetup: func() {
mockService.EXPECT().GetAllCloudEvents(gomock.Any(), gomock.Any(), gomock.Any()).Return(nil, nil)
},
vehTknID: uint32(invalidVehTknID),
vehTknID: invalidVehTknID,
},
}

Expand Down
5 changes: 5 additions & 0 deletions schema/attestation.graphqls
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,11 @@ type Attestation {
AttestationFilter holds the filter parameters for the attestation querys.
"""
input AttestationFilter {
"""
id is the id of the attestation.
"""
id: String

"""
The attesting party.
"""
Expand Down