Presign externalized payloads via data_index_key#79
Merged
Conversation
Adopt cloudevent v0.2.8: events whose payload was split into the blob bucket carry a data_index_key column in ClickHouse. Switch the GraphQL presign trigger from the cloudevent/blobs/ key prefix to a non-empty data_index_key, and presign that key against a new BLOB_BUCKET setting instead of the parquet bucket. CloudEvent responses for externalized events are now header-only at the eventrepo layer (the GraphQL resolver fills in dataUrl); other paths remain unchanged. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Member
Author
|
Need to make these damned buckets. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
data_index_keyClickHouse column carrying the blob-bucket key for events whose payload was split out of the inline event.cloudevent/blobs/key-prefix check todata_index_key != "", and presign that key against a newBLOB_BUCKETsetting instead of the parquet bucket.eventrepo.GetCloudEventFromIndexnow returns header-only — the GraphQL resolver fills indataUrl. This is a contract change, but per the cloudevent PR description no one was using the old prefix-based path.Notes
BLOB_BUCKETadded tointernal/config/settings.go,settings.sample.yaml, and both Helm values files (defaulting to the samedimo-storage-{dev,prod}bucketdiswrites to).ObjectInfoproto is unchanged for now — it does not surfacedata_index_key, so gRPC consumers of externalized events get header-only responses with nodataUrlfield. Happy to add it in a follow-up if needed.parquet.SeekToRow/pr.SeekToRownow returncloudevent.StoredEvent; we unwrap toRawEventfor existing callers, so behavior is preserved for non-externalized events.Test plan
go vet ./...go test -count=1 -short ./...(incl. ClickHouse-backed integration tests)latestCloudEvent/cloudEventsreturnsdataUrlfor an event with a non-emptydata_index_keyand inlinedataotherwise🤖 Generated with Claude Code