Skip to content

SM-763 add failing test for honda vin proto7 #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
JamesReate wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

SM-763 add failing test for honda vin proto7 #48

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
02251f7
add failing test for honda vin proto7
JamesReate Apr 13, 2024
567511b
notes
JamesReate Apr 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions internal/loggers/vin_logger_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,19 @@ func Test_extractVIN(t *testing.T) {
7e82220202020202020`,
wantErr: true,
},
{
name: "Mateusz and Steve example VIN UDS, vin_18DB33F1_UDS",
hexValue: `|-
18DAF111101862F19011354A
18DAF1112136524534483734
18DAF11122424C3035363039
18DAF1112337000000555555
`,
wantVin: "5J6RE4H74BL056097",
// need to use the request pid to help decode to find start position, 354A is start in frame 1, 37 is last byte we want in frame 4, the rest is padding.
wantVinStartPos: 10,
wantErr: false,
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
Expand Down