feat(guidance): the pin ships end to end, and the G6 journeys are runnable - #72
Merged
Conversation
…nable
The G4 service methods for session guidance existed but no HTTP route
mounted them, so neither the UI nor the validation runner could pin -- the
feature was unshipped and G6's third journey was impossible. Now:
* routes: POST .../sessions/{id}/guidance pins one instruction verbatim
and DELETE .../guidance/{entryId} retires it, both answering with the
full session; a route test drives pin -> reload -> delivery-to-writer ->
unpin end to end.
* UI: a Session guidance strip above the composer -- pinned entries shown
verbatim with one-click unpin, plus a pin input -- fed from the session
payload so a reload restores it.
* e2e: the three Phase 1 deployed-proof journeys (roadmap G6) as a
live-gated Playwright spec, profile-parameterized so they run against
whichever team the comparison selects.
…rneys typed CI caught three slips: a duplicated guidance route pair (ruff F811), the guidance field landing inside the nested draftSeed type instead of on the session, and untyped page params in the journey spec.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Chasing G6's third journey exposed that session guidance was unshipped: the G4 service methods had no HTTP routes, so neither the UI nor the runner could pin. This PR mounts the routes (pin → full session back; unpin), adds the Session-guidance strip above the composer (verbatim entries, one-click unpin, survives reload — it lives on the session), and adds the three G6 journeys as a live-gated, profile-parameterized Playwright spec. Route test drives pin → reload → delivery-to-writer (sessionContext.guidance.entries) → unpin. Gateway 341 / UI 244 tests pass.