fix: disable unstable apple speech fallback - #17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up for voice input still producing no transcript.\n\nDiagnosis:\n- Microphone capture works and audio chunks reach the main process.\n- The failing path was Apple Speech fallback: the helper exits with code null in app logs and reproduces a local 134 crash with PCM input.\n- The installed app also lacked Volcengine credentials until the local .env was included during packaging.\n\nChange:\n- Disable Apple Speech fallback by default unless SARAH_ENABLE_APPLE_SPEECH_FALLBACK=true is explicitly set.\n- Current local install was rebuilt with Volcengine .env present, so Sarah uses the streaming ASR path instead of the crashing helper.\n\nVerification:\n- node --experimental-strip-types --check passed for ASR files.\n- pnpm -s test passed 45/45.\n- pnpm run install:app completed successfully.\n- Installed app startup log shows .env loaded and VOLCENGINE_APP_ID SET.