Skip to content

Area plot clean up#1306

Merged
JustinElms merged 6 commits into
masterfrom
area-plot-updates
Jul 9, 2026
Merged

Area plot clean up#1306
JustinElms merged 6 commits into
masterfrom
area-plot-updates

Conversation

@JustinElms

@JustinElms JustinElms commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Background

This address three bugs in the area plotter and cleans up some inefficient code:

  • Correctly removes lakes from the basemap layer so that inland datasets (e.g. WCPS) are visible in the plot.
  • Correctly wraps bathymetry contours at edges of projection
  • Fix plot size bounding logic to prevent edge case errors

Why did you take this approach?

The geometry splitting approach used previous doesn't seem to fix issues at the projection bounds and adds a lot of unnecessary code.

Anything in particular that should be highlighted?

There are still some edge cases where the orientation of area polygons crossing the dateline in all projections can get reversed. To prevent this it might be best to get the centroid from the feature in the UI map component and include it with the plot query.

Checks

  • I ran unit tests.
  • I've tested the relevant changes from a user POV.
  • I've formatted my Python code using black ..

@JustinElms JustinElms self-assigned this Jun 16, 2026
@JustinElms JustinElms added Bugfix A fix for something broken. Python Code Quality Anything related to the quality of the code labels Jun 16, 2026
@JustinElms JustinElms marked this pull request as ready for review June 18, 2026 12:38
@JustinElms JustinElms requested a review from Emirate009 June 18, 2026 12:38
@JustinElms JustinElms merged commit 119ca67 into master Jul 9, 2026
7 checks passed
@JustinElms JustinElms deleted the area-plot-updates branch July 9, 2026 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bugfix A fix for something broken. Code Quality Anything related to the quality of the code Python

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant