Added handling for stub JSON files#1304
Merged
Merged
Conversation
dataset_config.py and settings.py. Updated settings.json to include new configurations.
+ removed cache variable from tests
to two variables: dataset_config_file and dataset_config_stub_path. Now works with testing files
JustinElms
approved these changes
Jun 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added handling for stub JSON files to dataset_config.py. Updated settings.json to include new configurations.
Background
dataset_configs.py now populates datasetconfigs.json from stubs JSON files
Why did you take this approach?
Maintainability
Anything in particular that should be highlighted?
settings.py variable dataset_config_file changed to dataset_config_path for use with stubs
Screenshot(s)
Checks
black ..Hint To run all python unit tests run the following command from the root repository directory: