Skip to content

fix(walletapi): guard TokenAdd against nil EntriesNative map #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DHEBP wants to merge 1 commit into
base: community-dev
Choose a base branch
from
Open

fix(walletapi): guard TokenAdd against nil EntriesNative map #44

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions walletapi/wallet.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,6 +153,14 @@ func (w *Wallet_Memory) TokenAdd(scid crypto.Hash) (err error) {
w.Lock()
defer w.Unlock()

// Guard against a nil map on a freshly created/restored, not-yet-synced
// wallet (EntriesNative is populated lazily during sync). Without this the
// assignment below panics with "assignment to entry in nil map". Mirrors the
// guard already present in InsertReplace.
if w.account.EntriesNative == nil {
w.account.EntriesNative = map[crypto.Hash][]rpc.Entry{}
}

if _, ok := w.account.EntriesNative[scid]; !ok {
w.account.EntriesNative[scid] = []rpc.Entry{}
} else {
Expand Down