chore(deps): bump vendored gorilla/websocket to v1.5.3#41
Open
moralpriest wants to merge 1 commit into
Open
Conversation
Drop-in vendor source swap of github.com/gorilla/websocket from the old
vendored copy to upstream v1.5.3. Verified backward-compatible: zero
consumer changes across all 13 call sites (derod /ws, walletapi rpcserver +
xswd, dero-miner, explorer, glue/rwc adapter). Adds
TestGorillaWebsocketRoundTrip exercising both the Upgrader (server) and
Dialer (client) for a text echo.
Builds under the repo's go 1.17 directive (v1.5.3 targets go 1.12; the new
tls_handshake.go / tls_handshake_116.go are go1.17 / !go1.17 build-tagged,
matching the toolchain).
Note: a pre-existing `go vet` warning in cmd/derod/main.go:1064
("unreachable code") is unrelated to this change and left untouched.
This was referenced Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Drop-in vendor source swap of
github.com/gorilla/websocketfrom the old vendored copy to upstream v1.5.3, as part of the dependency-prep track ahead of a future Go toolchain bump (see #40 for the nbio precedent)./ws(cmd/derod/rpc/websocket_server.go), walletapi rpcserver + xswd, dero-miner, explorer, and the glue/rwc adapter (glue/rwc/rwc.go; wasm path uses coder/websocket and is unaffected).TestGorillaWebsocketRoundTrip(cmd/derod/rpc/gorilla_websocket_test.go) exercises both theUpgrader(server) andDialer(client) for a text echo.go 1.17directive: v1.5.3 targetsgo 1.12; the newtls_handshake.go/tls_handshake_116.goarego1.17/!go1.17build-tagged, matching the toolchain. No new transitive requires (self-contained).client_clone*.go,conn_write*.go,trace*.go(absorbed intoconn.go/client.goupstream). Nogo.mod/go.sum/modules.txtchanges (repo convention: vendor-only, no requires).Verification
go build ./...→ greengo vet ./cmd/derod/rpc/ ./cmd/derod/ ./cmd/dero-miner/ ./cmd/explorer/explorerlib/ ./glue/... ./walletapi/...→ clean except a pre-existing unrelated warningcmd/derod/main.go:1064 unreachable code(untouched by this change)go test ./cmd/derod/rpc/ -run TestGorillaWebsocketRoundTrip→ PASSNote
A pre-existing
go vetwarning incmd/derod/main.go:1064("unreachable code") is unrelated to this change and left untouched to keep the PR focused.