fix(metrics): remove deprecated FECShortShards and add new KCP metrics#39
Open
moralpriest wants to merge 1 commit into
Open
fix(metrics): remove deprecated FECShortShards and add new KCP metrics#39moralpriest wants to merge 1 commit into
moralpriest wants to merge 1 commit into
Conversation
- Remove deprecated KCP_FECShortShards metric (field removed in kcp-go v5.6.72) - Add new KCP SNMP metrics: FECFullShardSet, FECShardSet, FECShardMin, RingBufferSndQueue, RingBufferRcvQueue, RingBufferSndBuffer, OOBPackets - Vendor kcp-go v5.6.72 (replaces old ~2020 vendored copy) without touching go.mod - Drop dead vendored deps github.com/templexxx/cpu and templexxx/xorsimd (only imported by the old kcp-go; new version uses klauspost/cpuid/v2) All 30 Snmp struct fields are now exported. Preparatory work for the eventual go.mod modernization (PR DEROFDN#19). API compatibility verified: kcp-go v5.6.72 symbol signatures used by metrics.go and p2p/controller.go are identical to the prior version.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Remove deprecated
KCP_FECShortShardsmetric and add 7 new KCP SNMP metrics, vendoring kcp-go v5.6.72 to support them.Why
FECShortShardsfield from itsSnmpstruct, causing a compile error against the current vendored copy (~2020)FECFullShardSet,FECShardSet,FECShardMin,RingBufferSndQueue,RingBufferRcvQueue,RingBufferSndBuffer,OOBPacketsChanges
metrics/metrics.goKCP_FECShortShards; added 7 new metrics; grouped importsvendor/github.com/xtaci/kcp-go/v5/.gofiles)vendor/github.com/templexxx/go.mod/go.sumgo 1.17, no go.sumVerification
metrics.goandp2p/controller.gohave identical signatures in v5.6.72go build ./metrics/ ./p2p/— passesgo vet ./metrics/ ./p2p/— passesgo test ./metrics/ ./p2p/— passesKCP_FECShortShardsis absentgo 1.17directive does not block kcp-go v5.6.72's generics (each module uses its own go directive)Notes
018a95f6can be dropped from chore(deps): migrate jrpc2 v0 → v1.3.5 #19 andgo mod vendorre-run to sync the vendor directoryNewRingBuffer[T]), which requires Go 1.18+ — but this is per-module: kcp-go's own go.mod saysgo 1.24.0, so it compiles fine withgo 1.17in the main module