Skip to content

fix(walletapi): add configurable 10s timeout to RPC calls #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
moralpriest wants to merge 1 commit into
base: community-dev
Choose a base branch
from
Open

fix(walletapi): add configurable 10s timeout to RPC calls #25

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion walletapi/daemon_communication.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@ var Connected bool = false
var daemon_height int64
var daemon_topoheight int64
var last_event_topoheight_tracked int64
var rpcCallTimeout = 10 * time.Second // per-call timeout preventing hangs on dead connections

@Dirtybird99 Dirtybird99 Jul 11, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
var rpcCallTimeout = 10 * time.Second // per-call timeout preventing hangs on dead connections
var RPCCallTimeout = 10 * time.Second // per-call timeout preventing hangs on dead connections; consumers may override


// return daemon height
func Get_Daemon_Height() int64 {
Expand Down Expand Up @@ -219,7 +220,9 @@ func (w *Wallet_Memory) sync_loop() {
}

func (cli *Client) Call(method string, params interface{}, result interface{}) error {
return cli.RPC.CallResult(context.Background(), method, params, result)
ctx, cancel := context.WithTimeout(context.Background(), rpcCallTimeout)

@Dirtybird99 Dirtybird99 Jul 11, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
ctx, cancel := context.WithTimeout(context.Background(), rpcCallTimeout)
ctx, cancel := context.WithTimeout(context.Background(), RPCCallTimeout)

defer cancel()
return cli.RPC.CallResult(ctx, method, params, result)
}

// returns whether wallet was online some time ago
Expand Down