feat/df-1225: Translates error description if applicable

[jbarnsley10]

Proposed change

Error description can be used to override error messages (whereas shortDescription is always used for Check Your Answers).
Handles translation of errorDescription for errors, if necessary

NOTE - I may have missed other areas where error description should override. Please check this PR thoroughly

Jira ticket: DF-1225

Type of change

• Bug fix
• New feature
• Breaking change
• Misc. (documentation, build updates, etc)

Checklist

• You have executed this code locally and it performs as expected.
• You have added tests to verify your code works.
• You have added code comments and JSDoc, where appropriate.
• There is no commented-out code.
• You have added developer docs in README.md and docs/* (where appropriate, e.g. new features).
• The tests are passing (npm run test).
• The linting checks are passing (npm run lint).
• The code has been formatted (npm run format).

[alexluckett]

same bug as we previously discussed, field is not a componentdef. possibly this.def?

[jbarnsley10]

Ok, thanks. It works because it just needs the component id, but I will correct

[jbarnsley10]

It's not possible to directly convert a Field to a ComponentDef. this.def is never saved in the ComponentBase, only certain properties from def.
Therefore, as the translator only needs the id, all I can really do is something liek this:

const componentDefWithId = { id: field.id } as unknown as ComponentDef
          const translatedLabel =
            translator.tComponent(componentDefWithId, 'errorDescription') ||
            translator.tComponent(componentDefWithId, 'shortDescription') ||
            translator.tComponent(componentDefWithId, 'title')

What do you think?

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
87.5% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud