#2530: Change default procs list for tests to run by chadalon · Pull Request #2531 · DARMA-tasking/vt

chadalon · 2026-10-01T15:23:21Z

Changes default behavior to run tests on 4 selections of nodes/procs: 1,2,max, and a power of 2 in between 2 and max
Adds CMake variable vt_tests_all_proc_scales to test on all powers of 2 up to max (existing default behavior). Only matters when not supplying vt_tests_num_nodes. Passed vt_tests_all_proc_scales through scripts and dockerfiles

Now the default behavior will only generate 4 combinations of each test, making the test running process faster.

github-actions · 2026-10-01T15:23:37Z

clang-format output for this changeset:

no modified files to format

codacy-production · 2026-10-01T15:24:14Z

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

_{NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer}
_{TIP This summary will be updated as you push new changes.}

github-actions · 2026-10-01T15:25:30Z

Pipelines results

vt-build-amd64-ubuntu-24-04-gcc-14-cpp

Build for 20437f1 (2026-10-09 17:01:21 UTC)

Compilation – successful

Testing – passed

View job log

vt-build-amd64-ubuntu-24-04-clang-18-cpp

Build for 20437f1 (2026-10-09 17:01:21 UTC)

Compilation – successful

Testing – passed

View job log

vt-build-amd64-ubuntu-24-04-clang-16-vtk-cpp

Build for 20437f1 (2026-10-09 17:01:21 UTC)

Compilation – successful

Testing – passed

View job log

vt-build-amd64-ubuntu-22-04-gcc-12-cpp

Build for 20437f1 (2026-10-09 17:01:21 UTC)

Compilation – successful

Testing – passed

View job log

vt-build-amd64-ubuntu-20-04-clang-9-cpp

Build for d62382e (2026-10-05 17:52:28 UTC)

Compilation – successful

Testing – passed

View job log

vt-build-amd64-ubuntu-22-04-clang-12-cpp

Build for 20437f1 (2026-10-09 17:01:21 UTC)

Compilation – successful

Testing – passed

View job log

vt-build-amd64-ubuntu-20-04-gcc-9-cpp

Build for 20437f1 (2026-10-09 17:01:21 UTC)

Compilation – successful

Testing – passed

View job log

vt-build-amd64-ubuntu-22-04-clang-11-cpp

Build for 20437f1 (2026-10-09 17:01:21 UTC)

Compilation – successful

Testing – passed

View job log

vt-build-amd64-ubuntu-22-04-clang-15-cpp-cxx20

Build for 20437f1 (2026-10-09 17:01:21 UTC)

Compilation – successful

Testing – passed

View job log

vt-build-amd64-alpine-3-16-clang-cpp

Build for 20437f1 (2026-10-09 17:01:21 UTC)

Compilation – successful

Testing – passed

View job log

vt-build-amd64-ubuntu-20-04-gcc-10-openmpi-cpp

Build for 20437f1 (2026-10-09 17:01:21 UTC)

Compilation – successful

Testing – passed

View job log

vt-build-amd64-ubuntu-22-04-clang-14-cpp

Build for 20437f1 (2026-10-09 17:01:21 UTC)

Compilation – successful

Testing – passed

View job log

vt-build-amd64-ubuntu-24-04-clang-17-cpp

Build for 20437f1 (2026-10-09 17:01:21 UTC)

Compilation – successful

Testing – passed

View job log

vt-build-amd64-ubuntu-20-04-gcc-9-ldms-cpp

Build for 20437f1 (2026-10-09 17:01:21 UTC)

Compilation – successful

Testing – passed

View job log

vt-build-amd64-ubuntu-22-04-clang-13-cpp

Build for 20437f1 (2026-10-09 17:01:21 UTC)

Compilation – successful

Testing – passed

View job log

vt-build-amd64-ubuntu-24-04-clang-16-zoltan-cpp

Build for d62382e (2026-10-05 17:52:28 UTC)

Compilation – successful

Testing – passed

View job log

vt-build-amd64-ubuntu-22-04-gcc-12-vtk-cpp

Build for 20437f1 (2026-10-09 17:01:21 UTC)

Compilation – successful

Testing – passed

View job log

vt-build-amd64-ubuntu-24-04-gcc-13-cpp

Build for 20437f1 (2026-10-09 17:01:21 UTC)

Compilation – successful

Testing – passed

View job log

vt-build-amd64-ubuntu-24-04-icpx-cpp

Build for 20437f1 (2026-10-09 17:01:21 UTC)

Compilation – successful

Testing – passed

View job log

vt-build-amd64-ubuntu-20-04-gcc-10-cpp

Build for 20437f1 (2026-10-09 17:01:21 UTC)

Compilation – successful

Testing – passed

View job log

vt-build-amd64-ubuntu-20-04-gcc-9-cuda-12-2-0-cpp

Build for 20437f1 (2026-10-09 17:01:21 UTC)

/vt/lib/fmt/include/fmt-vt/base.h(458): warning #128-D: loop is not reachable
    for (; n != 0; ++s1, ++s2, --n) {
    ^
          detected during:
            instantiation of "auto fmt::v12::detail::compare(const Char *, const Char *, size_t)->int [with Char=char]" at line 573
            instantiation of "auto fmt::v12::basic_string_view<Char>::compare(fmt::v12::basic_string_view<Char>) const->int [with Char=char]" at line 580
            instantiation of class "fmt::v12::basic_string_view<Char> [with Char=char]" at line 2624
            instantiation of "auto fmt::v12::basic_format_args<Context>::get_id(fmt::v12::basic_string_view<Char>) const->int [with Context=fmt::v12::context, Char=char]" at line 2661

Remark: The warnings can be suppressed with "-diag-suppress <warning-number>"

/vt/lib/fmt/include/fmt-vt/format.h(2775): warning #2417-D: constexpr constructor calls non-constexpr function "fmt::v12::basic_memory_buffer<T, SIZE, Allocator>::basic_memory_buffer(const Allocator &) [with T=fmt::v12::detail::bigint::bigit, SIZE=32UL, Allocator=fmt::v12::detail::allocator<fmt::v12::detail::bigint::bigit>]"
    constexpr bigint() : exp_(0) {}
                                 ^

/vt/lib/fmt/include/fmt-vt/base.h(458): warning #128-D: loop is not reachable
    for (; n != 0; ++s1, ++s2, --n) {
    ^
          detected during:
            instantiation of "auto fmt::v12::detail::compare(const Char *, const Char *, size_t)->int [with Char=char]" at line 573
            instantiation of "auto fmt::v12::basic_string_view<Char>::compare(fmt::v12::basic_string_view<Char>) const->int [with Char=char]" at line 580
            instantiation of class "fmt::v12::basic_string_view<Char> [with Char=char]" at line 2624
            instantiation of "auto fmt::v12::basic_format_args<Context>::get_id(fmt::v12::basic_string_view<Char>) const->int [with Context=fmt::v12::context, Char=char]" at line 2661

Remark: The warnings can be suppressed with "-diag-suppress <warning-number>"

/

 ==> And there is more. Read log. <==

View job log

vt-build-amd64-ubuntu-20-04-gcc-9-cuda-11-4-3-cpp

Build for 20437f1 (2026-10-09 17:01:21 UTC)

/vt/src/vt/pipe/pipe_manager.impl.h(135): warning: missing return statement at end of non-void function "vt::pipe::PipeManager::makeSend<f,Target>(Target) [with f=&vt::vrt::collection::lb::GreedyLB::collectHandler, Target=vt::objgroup::proxy::ProxyElm<vt::vrt::collection::lb::GreedyLB>]"
          detected during:
            instantiation of "auto vt::pipe::PipeManager::makeSend<f,Target>(Target) [with f=&vt::vrt::collection::lb::GreedyLB::collectHandler, Target=vt::objgroup::proxy::ProxyElm<vt::vrt::collection::lb::GreedyLB>]" 
/vt/src/vt/objgroup/proxy/proxy_objgroup.impl.h(221): here
            instantiation of "vt::objgroup::proxy::Proxy<ObjT>::PendingSendType vt::objgroup::proxy::Proxy<ObjT>::reduce<f,Op,Target,Args...>(Target, Args &&...) const [with ObjT=vt::vrt::collection::lb::GreedyLB, f=&vt::vrt::collection::lb::GreedyLB::collectHandler, Op=vt::collective::PlusOp, Target=vt::objgroup::proxy::ProxyElm<vt::vrt::collection::lb::GreedyLB>, Args=<vt::vrt::collection::lb::GreedyPayload>]" 
/vt/src/vt/vrt/collection/balance/greedylb/greedylb.cc(222): here

/vt/src/vt/pipe/pipe_manager.impl.h(135): warning: missing return statement at end of non-void function "vt::pipe::PipeManager::makeSend<f,Target>(Target) [with f=&vt::vrt::collection::lb::TemperedLB::remoteBlockCountHandler, Target=vt::objgroup::proxy::ProxyElm<vt::vrt::collection::lb::TemperedLB>]"
          detected during:
            instantiation of "auto vt::pipe::PipeManager::makeSend<f,Target>(Target) [with f=&vt::vrt::collection::lb::TemperedLB::remoteBlockCountHandler, Target=vt::objgroup::proxy::ProxyElm<vt::vrt::collection::lb::TemperedLB>]" 
/vt/src/vt/objgroup/proxy/proxy_objgroup.impl.h(221): here
            instantiation of "vt::objgroup::proxy::Proxy<ObjT>::PendingSendType vt::objgroup::proxy::Proxy<ObjT>::reduce<f,Op,Target,Args...>(Target, Args &&...) const [with ObjT=vt::vrt::collection::lb::TemperedLB, f=&vt::vrt::collection::lb::TemperedLB::remoteBlockCountHandler, Op=vt::collective::

 ==> And there is more. Read log. <==

View job log

vt-build-amd64-ubuntu-22-04-gcc-11-cpp

Build for 20437f1 (2026-10-09 17:01:21 UTC)

Compilation – successful

Testing – passed

View job log

vt-build-amd64-ubuntu-20-04-clang-10-cpp

Build for 20437f1 (2026-10-09 17:01:21 UTC)

Compilation – successful

Testing – passed

View job log

vt-build-amd64-ubuntu-24-04-gcc-14-cpp-docs

Build for 20437f1 (2026-10-09 17:01:21 UTC)

Compilation – successful

Testing – passed

View job log

vt-build-amd64-ubuntu-20-04-gcc-10-openmpi-cpp-spack

Build for 20437f1 (2026-10-09 17:01:21 UTC)

Compilation – successful

Testing – passed

View job log

codecov · 2026-10-01T15:52:45Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.51%. Comparing base (fb9218b) to head (641cf88).

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #2531      +/-   ##
===========================================
- Coverage    88.52%   88.51%   -0.02%     
===========================================
  Files          728      728              
  Lines        31028    31028              
===========================================
- Hits         27468    27463       -5     
- Misses        3560     3565       +5

see 2 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

antoinemeyer5 · 2026-10-06T07:30:06Z

Need #2535 to fix Spack issue

…cts 4 values

lifflander

LGTM

chadalon force-pushed the 2530-allow-passing-explicit-list-over-default-build_mpi_proc_test_list-behavior branch from bdc4686 to 9950aab Compare October 2, 2026 16:00

chadalon requested review from antoinemeyer5, cwschilly, lifflander and nlslatt October 2, 2026 16:20

chadalon changed the title ~~#2530: Allow passing explicit list over default build_mpi_proc_test_list behavior~~ #2530: Change default procs list for tests to run Oct 2, 2026

antoinemeyer5 approved these changes Oct 6, 2026

View reviewed changes

chadalon added 3 commits October 9, 2026 13:00

#2530: Flag for testing on procs up to the max; default behavior sele…

920ecbc

…cts 4 values

#2530: Forward vt_tests_all_proc_scales in scripts etc

29c517c

#2530: Ensure scales are only powers of 2

641cf88

chadalon force-pushed the 2530-allow-passing-explicit-list-over-default-build_mpi_proc_test_list-behavior branch from 5d5a52b to 641cf88 Compare October 9, 2026 17:01

lifflander approved these changes Oct 12, 2026

View reviewed changes

lifflander merged commit fd049ea into develop Oct 12, 2026
90 of 92 checks passed

Navigation Menu

Repository navigation

#2530: Change default procs list for tests to run - #2531

#2530: Change default procs list for tests to run#2531
lifflander merged 3 commits into
developfrom
2530-allow-passing-explicit-list-over-default-build_mpi_proc_test_list-behavior

chadalon commented Oct 1, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Oct 1, 2026

Uh oh!

codacy-production Bot commented Oct 1, 2026

Uh oh!

github-actions Bot commented Oct 1, 2026 •

edited

Loading

Uh oh!

codecov Bot commented Oct 1, 2026 •

edited

Loading

Uh oh!

antoinemeyer5 commented Oct 6, 2026

Uh oh!

lifflander left a comment

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

chadalon commented Oct 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Oct 1, 2026

Uh oh!

codacy-production Bot commented Oct 1, 2026

Up to standards ✅

Uh oh!

github-actions Bot commented Oct 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pipelines results

Uh oh!

codecov Bot commented Oct 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

antoinemeyer5 commented Oct 6, 2026

Uh oh!

lifflander left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

chadalon commented Oct 1, 2026 •

edited

Loading

github-actions Bot commented Oct 1, 2026 •

edited

Loading

codecov Bot commented Oct 1, 2026 •

edited

Loading