Repository navigation
Keep mask playback state accurate after play rejection - #35
Open
rudycelekli wants to merge 4 commits into
Open
rudycelekli wants to merge 4 commits into
rudycelekli wants to merge 4 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The mask review switches its button to Pause immediately after calling
video.play(). If playback is rejected, the rejected promise goes unhandled and the UI claims the video is playing.Track playback through native play/pause events, handle play rejection with a retryable error, and discard errors from superseded attempts or an expired review. Frame stepping still pauses playback.
Validation: mounted React regression fails before the fix because rejected playback leaves Pause visible. Afterward it verifies the error, successful retry, pause, pending-play state, and an obsolete rejection arriving after a newer successful attempt.
npm testpasses 127 tests and TypeScript. The media API is controlled in jsdom; native codec/GPU behavior was not qualified.