Timeline markers for notes across complete playlists - #33
Merged
Conversation
Ported from reviewapp Timeline.set_markers. A reviewer scrubbing a shot can now see where the notes are instead of hunting for them. Colours and shape follow reviewapp: a 3px tick per annotated frame, blue for a frame holding comments and purple for one holding only drawings. A frame with both reads as a comment, because the words are the reviewable part and the drawing marker must not hide them. The markers are drawn under the playhead, so a note never hides the frame the reviewer is actually sitting on. Annotations are keyed by the player LOCAL frame while the timeline is a global range during playlist playback, so every marker is mapped across with _timeline_frame_for_local. Without that the notes for one shot land on another. Drawing a stroke changes what the timeline should show and only the viewer knows it happened, so ViewerWidget gains an annotations_changed signal, emitted when a stroke is completed, undone, redone or cleared. Comment add/delete/resolve and the sidecar load already funnel through single call sites, so the refresh hangs off those. 10 tests. The timeline is a plain QWidget, so they render it offscreen and probe the real pixels: the marker colours, a both-kinds frame reading as a comment, an unannotated frame staying clean, out-of-range markers not smearing onto the track ends, and the playhead winning the pixel it shares with a marker. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TexnzYbmCjjTDB8zzZuUPb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
This supersedes #28 while preserving and extending the contributor's marker implementation.