Repository navigation
Fix .NET 6 Guid conversion on CPUs without SSSE3 - #118
Open
dajiaohuang wants to merge 1 commit into
Open
dajiaohuang wants to merge 1 commit into
dajiaohuang wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On .NET 6 with SSE3 available but SSSE3 unavailable,
Ulid.ToGuid()andnew Ulid(Guid)enter the vector shuffle path, then throwNotImplementedException. This prevents the advertised Guid conversion even for ordinary valid ULIDs. This matches the report in #106 (closed by the stale automation, with no maintainer rejection).IsVector128SupportedchecksSse3.IsSupported, whileShuffleactually requiresSsse3.IsSupportedon .NET 6.Change
Require SSSE3 at the existing dispatch point so unsupported processors use the existing scalar conversion. No additional fallback, retry, public API or byte mapping changes. The Unity copy was regenerated by the existing
Ulid.csprojpost-build copy target.Validation
NotImplementedExceptionusingdotnet test tests/Ulid.Tests/Ulid.Tests.csproj -c Release -p:TargetFramework=net6.0 -p:TargetFrameworks=net6.0 --environment COMPlus_EnableSSSE3=0 --filter FullyQualifiedName~Guid.DOTNET_ROLL_FORWARD=Majorbecause native .NET 7 is not installed.Tested on Windows x64, SDK 10.0.100. Existing EOL/dependency/assembly warnings remain. Unity editor, big-endian hardware and physical SSE3-only hardware were not exercised; no performance claim is made.