Repository navigation
Minor changes to Link Audio Editing and Desctruction patters - #361
Merged
Merged
Conversation
…ts of the UI to trigger delete and renaming actions, also reuse the async dialogues here rather than deleting directly as well as when asking for naming / renaming input
x37v
approved these changes
Sep 14, 2026
x37v
left a comment
x37v
left a comment
Collaborator
There was a problem hiding this comment.
one little cleanup comment, otherwise looks good, thanks for ditching the touch screen language
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes sit on top of the changes from
feature/linkaudioand aim at reusing the existing UX patterns for gating destructive actions and requesting user input. This way the actual logic and validation lives in the actions, rather than dragging a lot of code and state throughout the app and components.Additionally adjusted the display of the stats of a Peer channel in order to avoid constant realignment and set 2 and 4 column layouts depending on screensize.