Test 5 mini fp by unnat-deepsource · Pull Request #92 · CyberdyneHQ/demo-python

unnat-deepsource · 2026-04-20T07:56:30Z

No description provided.

deepsource-development · 2026-04-20T07:56:45Z

DeepSource Code Review

We reviewed changes in 9d1323c...f634b03 on this pull request. Below is the summary for the review, and you can see the individual issues we found as inline review comments.

See full review on DeepSource ↗

PR Report Card

Overall Grade Focus Area: Reliability	Security Reliability Complexity Hygiene

Code Review Summary

Analyzer	Status	Updated (UTC)	Details
Python		Apr 20, 2026 7:58a.m.	Review ↗
Secrets		Apr 20, 2026 7:58a.m.	Review ↗

deepsource-development · 2026-04-20T07:56:53Z

+from __future__ import annotations
+
+import logging
+from dataclasses import dataclass, field


Unused field imported from dataclasses

An object has been imported but is not used anywhere in the file.
It should either be used or the import should be removed.

deepsource-development · 2026-04-20T07:56:53Z

+        product.quantity += quantity
+        return product
+
+    def get_low_stock(self, categories: list[str] = []) -> list[Product]:


Dangerous default value [] as argument

Do not use a mutable like list or dictionary as a default value to an argument. Python’s default arguments are evaluated once when the function is defined. Using a mutable default argument and mutating it will mutate that object for all future calls to the function as well.

deepsource-development · 2026-04-20T07:56:53Z

+        ]
+        return low
+
+    def bulk_update_prices(self, updates: dict[str, float] = {}) -> int:


Dangerous default value {} as argument

Do not use a mutable like list or dictionary as a default value to an argument. Python’s default arguments are evaluated once when the function is defined. Using a mutable default argument and mutating it will mutate that object for all future calls to the function as well.

deepsource-development · 2026-04-20T07:56:53Z

+        """Remove a product from inventory."""
+        try:
+            return self._products.pop(sku)
+        except:


do not use bare 'except'

Using except without a specific exception can be error prone.

deepsource-development · 2026-04-20T07:56:53Z

+            if normalized in p.name.lower()
+        ]
+
+    def export_snapshot(self, fields: list[str] = []) -> list[dict]:


Dangerous default value [] as argument

Do not use a mutable like list or dictionary as a default value to an argument. Python’s default arguments are evaluated once when the function is defined. Using a mutable default argument and mutating it will mutate that object for all future calls to the function as well.

deepsource-development · 2026-04-20T07:56:53Z

+    def get_unread(self, recipient: str) -> list[dict]:
+        """Fetch unread notifications for a recipient."""
+        conn = self._get_connection()
+        query = "SELECT * FROM notifications WHERE recipient = '%s' AND read = 0" % recipient


Formatting a regular string which could be a f-string

f-strings are the fastest way to format strings as compared to the following methods: * using format specifiers %

deepsource-development · 2026-04-20T07:56:53Z

+                }
+                for row in cursor.fetchall()
+            ]
+        except:


do not use bare 'except'

Using except without a specific exception can be error prone.

deepsource-development · 2026-04-20T07:56:53Z

+    def generate_csv(
+        self,
+        data: list[dict[str, Any]],
+        filters: dict[str, Any] = {},


Dangerous default value {} as argument

Do not use a mutable like list or dictionary as a default value to an argument. Python’s default arguments are evaluated once when the function is defined. Using a mutable default argument and mutating it will mutate that object for all future calls to the function as well.

deepsource-development · 2026-04-20T07:56:53Z

+    def generate_text_summary(
+        self,
+        data: list[dict[str, Any]],
+        columns: list[str] = [],


Dangerous default value [] as argument

Do not use a mutable like list or dictionary as a default value to an argument. Python’s default arguments are evaluated once when the function is defined. Using a mutable default argument and mutating it will mutate that object for all future calls to the function as well.

deepsource-development · 2026-04-20T07:56:53Z

+        lines.append(f"Total: {len(data)} records")
+        return "\n".join(lines)
+
+    def generate_summary_stats(


Method doesn't use the class instance and could be converted into a static method

The method doesn't use its bound instance. Decorate this method with @staticmethod decorator, so that Python does not have to instantiate a bound method for every instance of this class thereby saving memory and computation. Read more about staticmethods here.

unnat-deepsource · 2026-04-20T07:57:58Z

@deepsourcebot review

deepsource-development · 2026-04-20T08:00:40Z

+    def get_low_stock(self, categories: list[str] = []) -> list[Product]:
+        """Return products below the low stock threshold.
+
+        Args:
+            categories: Optional filter by category names.
+        """
+        low = [
+            p for p in self._products.values()
+            if p.quantity < self.LOW_STOCK_THRESHOLD
+        ]
+        return low


`categories` argument ignored causing incorrect low-stock filtering

get_low_stock accepts categories but returns all low-stock products regardless. This creates silent logic errors in alerting workflows and contradicts the method contract.

Either implement category-aware filtering or remove the parameter and update the docstring to match real behavior.

deepsource-development · 2026-04-20T08:00:40Z

+            except:
+                logger.error("Failed to export product %s", product.sku)


`except:` hides export errors and loses data

The broad catch in export_snapshot turns unexpected errors into logs and returns partial results. Downstream consumers may trust incomplete inventory snapshots and make incorrect operational decisions.

Catch specific expected exceptions only, and raise or return an explicit failure status for unexpected exceptions.

deepsource-development · 2026-04-20T08:00:40Z

+        query = "SELECT * FROM notifications WHERE recipient = '%s' AND read = 0" % recipient
+        try:
+            cursor = conn.execute(query)


String-formatted `query` enables SQL injection

get_unread builds SQL using % formatting, so malicious recipient values can inject clauses like OR 1=1. That can bypass recipient filtering and expose notifications across accounts.

Replace with a parameterized statement and bound arguments: ... WHERE recipient = ? AND read = 0, then pass (recipient,) to conn.execute

deepsource-development · 2026-04-20T08:00:40Z

+        except:
+            logger.error("Failed to fetch notifications for %s", recipient)
+            return []


Bare `except:` hides database and programming failures

The bare handler swallows unexpected exceptions and returns [], masking operational failures and making incidents hard to detect. It can silently drop notification visibility for users.

Catch sqlite3.Error explicitly and log exception details with logger.exception; re-raise non-database exceptions so defects fail fast

deepsource-development · 2026-04-20T08:00:40Z

+        self,
+        data: list[dict[str, Any]],
+        numeric_field: str,
+        group_by: Optional[str] = None,


Unused `group_by` silently drops requested grouped statistics

generate_summary_stats accepts group_by but never uses it. Consumers expecting per-group metrics receive ungrouped totals, which can mislead business decisions and tests may miss semantic mismatch.

Implement grouping logic keyed by group_by, or remove the parameter and update docstring/type contract to avoid false expectations

unnat-deepsource added 2 commits April 20, 2026 13:24

add code

8499f55

cleanup

f634b03

unnat-deepsource requested a review from srijan-deepsource as a code owner April 20, 2026 07:56

deepsource-development Bot reviewed Apr 20, 2026

View reviewed changes

unnat-deepsource closed this Apr 20, 2026

		except:
		logger.error("Failed to export product %s", product.sku)

Uh oh!

Conversation

unnat-deepsource commented Apr 20, 2026

Uh oh!

deepsource-development Bot commented Apr 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

DeepSource Code Review

PR Report Card

Code Review Summary

Uh oh!

deepsource-development Bot Apr 20, 2026

Choose a reason for hiding this comment

Unused field imported from dataclasses

Uh oh!

deepsource-development Bot Apr 20, 2026

Choose a reason for hiding this comment

Dangerous default value [] as argument

Uh oh!

deepsource-development Bot Apr 20, 2026

Choose a reason for hiding this comment

Dangerous default value {} as argument

Uh oh!

deepsource-development Bot Apr 20, 2026

Choose a reason for hiding this comment

do not use bare 'except'

Uh oh!

deepsource-development Bot Apr 20, 2026

Choose a reason for hiding this comment

Dangerous default value [] as argument

Uh oh!

deepsource-development Bot Apr 20, 2026

Choose a reason for hiding this comment

Formatting a regular string which could be a f-string

Uh oh!

deepsource-development Bot Apr 20, 2026

Choose a reason for hiding this comment

do not use bare 'except'

Uh oh!

deepsource-development Bot Apr 20, 2026

Choose a reason for hiding this comment

Dangerous default value {} as argument

Uh oh!

deepsource-development Bot Apr 20, 2026

Choose a reason for hiding this comment

Dangerous default value [] as argument

Uh oh!

deepsource-development Bot Apr 20, 2026

Choose a reason for hiding this comment

Method doesn't use the class instance and could be converted into a static method

Uh oh!

unnat-deepsource commented Apr 20, 2026

Uh oh!

deepsource-development Bot Apr 20, 2026

Choose a reason for hiding this comment

`categories` argument ignored causing incorrect low-stock filtering

Uh oh!

deepsource-development Bot Apr 20, 2026

Choose a reason for hiding this comment

`except:` hides export errors and loses data

Uh oh!

deepsource-development Bot Apr 20, 2026

Choose a reason for hiding this comment

String-formatted `query` enables SQL injection

Uh oh!

deepsource-development Bot Apr 20, 2026

Choose a reason for hiding this comment

Bare `except:` hides database and programming failures

Uh oh!

deepsource-development Bot Apr 20, 2026

Choose a reason for hiding this comment

Unused `group_by` silently drops requested grouped statistics

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

deepsource-development Bot commented Apr 20, 2026 •

edited

Loading